Callback executed too early












1














I'm struggling with an issue I can't get around.



I'm using NodeJS to request data from Rest API´s. For this program I first retrieve an array of data, then I request some details from another endpoint based on an id from the first array.



I use a foreach loop inside the first function call with callback, and then another function call within the foreach loop to get the details.



What I experience is that the second function does callback before the response is retrieved.



I have managed to reproduce the issue with the following example code:



console.log('Program start')



// Executing program

getFirstname(function(person) {



    person.forEach(firstname => {



        getSurname(firstname.id, function(lastname) {

            console.log(`${firstname.value} ${lastname}`)

        });



    });

})



// Emulating REST API´s

function getFirstname(callback) {



    console.log('Returning list of firstnames')



    let data = [

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

        {id: 0, value: 'John'},

        {id: 2, value: 'Andy'},

        {id: 3, value: 'Jimmy'},

        {id: 4, value: 'Alex'},

    ]



    callback(data);

}



function getSurname(id, callback) {



    console.log(`Querying for lastname id ${id}`)



    let data = [

        'Andersen',

        'Johsen',

        'Falon',

        'Alexander',

    ]



    setTimeout(() => {

        callback(data[id]);

    }, 2000);

}


Here is the result of the program:



Program start

Returning list of firstnames

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

Querying for lastname id 0

Querying for lastname id 2

Querying for lastname id 3

Querying for lastname id 4

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined

John Andersen

Andy Falon

Jimmy Alexander

Alex undefined


As you can see, there are several records with undefined value. Also I have added a setTimeout to emulate that each rest call takes a few seconds. What happens is that all the queries are fired off instantly, then it goes 2 seconds before all the responses return simultaneous.



I would expect this to wait for each second rest call and then return the result.



How can I solve this issue?



Best regards,
Christian






javascript node.js loops foreach callback







share|improve this question





























    1














    I'm struggling with an issue I can't get around.



    I'm using NodeJS to request data from Rest API´s. For this program I first retrieve an array of data, then I request some details from another endpoint based on an id from the first array.



    I use a foreach loop inside the first function call with callback, and then another function call within the foreach loop to get the details.



    What I experience is that the second function does callback before the response is retrieved.



    I have managed to reproduce the issue with the following example code:



    console.log('Program start')
    

    
// Executing program
    
getFirstname(function(person) {
    

    
    person.forEach(firstname => {
    

    
        getSurname(firstname.id, function(lastname) {
    
            console.log(`${firstname.value} ${lastname}`)
    
        });
    

    
    });
    
})
    

    
// Emulating REST API´s
    
function getFirstname(callback) {
    

    
    console.log('Returning list of firstnames')
    

    
    let data = [
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
        {id: 0, value: 'John'},
    
        {id: 2, value: 'Andy'},
    
        {id: 3, value: 'Jimmy'},
    
        {id: 4, value: 'Alex'},
    
    ]
    

    
    callback(data);
    
}
    

    
function getSurname(id, callback) {
    

    
    console.log(`Querying for lastname id ${id}`)
    

    
    let data = [
    
        'Andersen',
    
        'Johsen',
    
        'Falon',
    
        'Alexander',
    
    ]
    

    
    setTimeout(() => {
    
        callback(data[id]);
    
    }, 2000);
    
}


    Here is the result of the program:



    Program start
    
Returning list of firstnames
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
Querying for lastname id 0
    
Querying for lastname id 2
    
Querying for lastname id 3
    
Querying for lastname id 4
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined
    
John Andersen
    
Andy Falon
    
Jimmy Alexander
    
Alex undefined


    As you can see, there are several records with undefined value. Also I have added a setTimeout to emulate that each rest call takes a few seconds. What happens is that all the queries are fired off instantly, then it goes 2 seconds before all the responses return simultaneous.



    I would expect this to wait for each second rest call and then return the result.



    How can I solve this issue?



    Best regards,
    Christian






    javascript node.js loops foreach callback







    share|improve this question



























      1












      1








      1







      I'm struggling with an issue I can't get around.



      I'm using NodeJS to request data from Rest API´s. For this program I first retrieve an array of data, then I request some details from another endpoint based on an id from the first array.



      I use a foreach loop inside the first function call with callback, and then another function call within the foreach loop to get the details.



      What I experience is that the second function does callback before the response is retrieved.



      I have managed to reproduce the issue with the following example code:



      console.log('Program start')
      

      
// Executing program
      
getFirstname(function(person) {
      

      
    person.forEach(firstname => {
      

      
        getSurname(firstname.id, function(lastname) {
      
            console.log(`${firstname.value} ${lastname}`)
      
        });
      

      
    });
      
})
      

      
// Emulating REST API´s
      
function getFirstname(callback) {
      

      
    console.log('Returning list of firstnames')
      

      
    let data = [
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
    ]
      

      
    callback(data);
      
}
      

      
function getSurname(id, callback) {
      

      
    console.log(`Querying for lastname id ${id}`)
      

      
    let data = [
      
        'Andersen',
      
        'Johsen',
      
        'Falon',
      
        'Alexander',
      
    ]
      

      
    setTimeout(() => {
      
        callback(data[id]);
      
    }, 2000);
      
}


      Here is the result of the program:



      Program start
      
Returning list of firstnames
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined


      As you can see, there are several records with undefined value. Also I have added a setTimeout to emulate that each rest call takes a few seconds. What happens is that all the queries are fired off instantly, then it goes 2 seconds before all the responses return simultaneous.



      I would expect this to wait for each second rest call and then return the result.



      How can I solve this issue?



      Best regards,
      Christian






      javascript node.js loops foreach callback







      share|improve this question















      I'm struggling with an issue I can't get around.



      I'm using NodeJS to request data from Rest API´s. For this program I first retrieve an array of data, then I request some details from another endpoint based on an id from the first array.



      I use a foreach loop inside the first function call with callback, and then another function call within the foreach loop to get the details.



      What I experience is that the second function does callback before the response is retrieved.



      I have managed to reproduce the issue with the following example code:



      console.log('Program start')
      

      
// Executing program
      
getFirstname(function(person) {
      

      
    person.forEach(firstname => {
      

      
        getSurname(firstname.id, function(lastname) {
      
            console.log(`${firstname.value} ${lastname}`)
      
        });
      

      
    });
      
})
      

      
// Emulating REST API´s
      
function getFirstname(callback) {
      

      
    console.log('Returning list of firstnames')
      

      
    let data = [
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
        {id: 0, value: 'John'},
      
        {id: 2, value: 'Andy'},
      
        {id: 3, value: 'Jimmy'},
      
        {id: 4, value: 'Alex'},
      
    ]
      

      
    callback(data);
      
}
      

      
function getSurname(id, callback) {
      

      
    console.log(`Querying for lastname id ${id}`)
      

      
    let data = [
      
        'Andersen',
      
        'Johsen',
      
        'Falon',
      
        'Alexander',
      
    ]
      

      
    setTimeout(() => {
      
        callback(data[id]);
      
    }, 2000);
      
}


      Here is the result of the program:



      Program start
      
Returning list of firstnames
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
Querying for lastname id 0
      
Querying for lastname id 2
      
Querying for lastname id 3
      
Querying for lastname id 4
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined
      
John Andersen
      
Andy Falon
      
Jimmy Alexander
      
Alex undefined


      As you can see, there are several records with undefined value. Also I have added a setTimeout to emulate that each rest call takes a few seconds. What happens is that all the queries are fired off instantly, then it goes 2 seconds before all the responses return simultaneous.



      I would expect this to wait for each second rest call and then return the result.



      How can I solve this issue?



      Best regards,
      Christian






      javascript node.js loops foreach callback




      javascript node.js loops foreach callback






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 13 at 15:06









      mihai

      23.3k73968




      23.3k73968










      asked Nov 12 at 20:21









      chranmat

      294




      294
























          2 Answers
          2






          active

          oldest

          votes


















          3














          The reason you have undefined is because your data array has length of 4 (indices go from 0 to 3) but your id's range from 0 to 4. Which means that when you reference data[4] you get undefined.






          share|improve this answer





















          • Your right. That was actually a typo in the example code, but I have this problem with my real code.
            – chranmat
            Nov 12 at 20:43



















          2














          There is nothing wrong with your callbacks. The data, however is incorrect. See below:



          function getSurname(id, callback) {
          

          
    console.log(`Querying for lastname id ${id}`)
          

          
    let data = [
          
        'Andersen',
          
        'Johsen',
          
        'Falon',
          
        'Alexander',
          
    ]
          

          
    setTimeout(() => {
          
        callback(data[id]);
          
    }, 2000);
          
}


          Everytime Alex is called, you're passing id 4 for use in your data array. Remember that array's are 0 based so data[4] = undefined...






          share|improve this answer





















          • Ref comment on previous answer. I can see I did a typo there and that my example actually works. This does not solve the problem in my real code :(
            – chranmat
            Nov 12 at 20:47










          • @chranmat No worries. Can you post your actual code please?
            – War10ck
            Nov 12 at 20:48










          • pastebin.com/XpcWUtrv
            – chranmat
            Nov 12 at 21:06











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53269520%2fcallback-executed-too-early%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          2 Answers
          2






          active

          oldest

          votes








          2 Answers
          2






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          3














          The reason you have undefined is because your data array has length of 4 (indices go from 0 to 3) but your id's range from 0 to 4. Which means that when you reference data[4] you get undefined.






          share|improve this answer





















          • Your right. That was actually a typo in the example code, but I have this problem with my real code.
            – chranmat
            Nov 12 at 20:43
















          3














          The reason you have undefined is because your data array has length of 4 (indices go from 0 to 3) but your id's range from 0 to 4. Which means that when you reference data[4] you get undefined.






          share|improve this answer





















          • Your right. That was actually a typo in the example code, but I have this problem with my real code.
            – chranmat
            Nov 12 at 20:43














          3












          3








          3






          The reason you have undefined is because your data array has length of 4 (indices go from 0 to 3) but your id's range from 0 to 4. Which means that when you reference data[4] you get undefined.






          share|improve this answer












          The reason you have undefined is because your data array has length of 4 (indices go from 0 to 3) but your id's range from 0 to 4. Which means that when you reference data[4] you get undefined.







          share|improve this answer












          share|improve this answer



          share|improve this answer










          answered Nov 12 at 20:28









          ODYN-Kon

          2,0841625




          2,0841625












          • Your right. That was actually a typo in the example code, but I have this problem with my real code.
            – chranmat
            Nov 12 at 20:43


















          • Your right. That was actually a typo in the example code, but I have this problem with my real code.
            – chranmat
            Nov 12 at 20:43
















          Your right. That was actually a typo in the example code, but I have this problem with my real code.
          – chranmat
          Nov 12 at 20:43




          Your right. That was actually a typo in the example code, but I have this problem with my real code.
          – chranmat
          Nov 12 at 20:43













          2














          There is nothing wrong with your callbacks. The data, however is incorrect. See below:



          function getSurname(id, callback) {
          

          
    console.log(`Querying for lastname id ${id}`)
          

          
    let data = [
          
        'Andersen',
          
        'Johsen',
          
        'Falon',
          
        'Alexander',
          
    ]
          

          
    setTimeout(() => {
          
        callback(data[id]);
          
    }, 2000);
          
}


          Everytime Alex is called, you're passing id 4 for use in your data array. Remember that array's are 0 based so data[4] = undefined...






          share|improve this answer





















          • Ref comment on previous answer. I can see I did a typo there and that my example actually works. This does not solve the problem in my real code :(
            – chranmat
            Nov 12 at 20:47










          • @chranmat No worries. Can you post your actual code please?
            – War10ck
            Nov 12 at 20:48










          • pastebin.com/XpcWUtrv
            – chranmat
            Nov 12 at 21:06
















          2














          There is nothing wrong with your callbacks. The data, however is incorrect. See below:



          function getSurname(id, callback) {
          

          
    console.log(`Querying for lastname id ${id}`)
          

          
    let data = [
          
        'Andersen',
          
        'Johsen',
          
        'Falon',
          
        'Alexander',
          
    ]
          

          
    setTimeout(() => {
          
        callback(data[id]);
          
    }, 2000);
          
}


          Everytime Alex is called, you're passing id 4 for use in your data array. Remember that array's are 0 based so data[4] = undefined...






          share|improve this answer





















          • Ref comment on previous answer. I can see I did a typo there and that my example actually works. This does not solve the problem in my real code :(
            – chranmat
            Nov 12 at 20:47










          • @chranmat No worries. Can you post your actual code please?
            – War10ck
            Nov 12 at 20:48










          • pastebin.com/XpcWUtrv
            – chranmat
            Nov 12 at 21:06














          2












          2








          2






          There is nothing wrong with your callbacks. The data, however is incorrect. See below:



          function getSurname(id, callback) {
          

          
    console.log(`Querying for lastname id ${id}`)
          

          
    let data = [
          
        'Andersen',
          
        'Johsen',
          
        'Falon',
          
        'Alexander',
          
    ]
          

          
    setTimeout(() => {
          
        callback(data[id]);
          
    }, 2000);
          
}


          Everytime Alex is called, you're passing id 4 for use in your data array. Remember that array's are 0 based so data[4] = undefined...






          share|improve this answer












          There is nothing wrong with your callbacks. The data, however is incorrect. See below:



          function getSurname(id, callback) {
          

          
    console.log(`Querying for lastname id ${id}`)
          

          
    let data = [
          
        'Andersen',
          
        'Johsen',
          
        'Falon',
          
        'Alexander',
          
    ]
          

          
    setTimeout(() => {
          
        callback(data[id]);
          
    }, 2000);
          
}


          Everytime Alex is called, you're passing id 4 for use in your data array. Remember that array's are 0 based so data[4] = undefined...







          share|improve this answer












          share|improve this answer



          share|improve this answer










          answered Nov 12 at 20:28









          War10ck

          10.1k62945




          10.1k62945












          • Ref comment on previous answer. I can see I did a typo there and that my example actually works. This does not solve the problem in my real code :(
            – chranmat
            Nov 12 at 20:47










          • @chranmat No worries. Can you post your actual code please?
            – War10ck
            Nov 12 at 20:48










          • pastebin.com/XpcWUtrv
            – chranmat
            Nov 12 at 21:06


















          • Ref comment on previous answer. I can see I did a typo there and that my example actually works. This does not solve the problem in my real code :(
            – chranmat
            Nov 12 at 20:47










          • @chranmat No worries. Can you post your actual code please?
            – War10ck
            Nov 12 at 20:48










          • pastebin.com/XpcWUtrv
            – chranmat
            Nov 12 at 21:06
















          Ref comment on previous answer. I can see I did a typo there and that my example actually works. This does not solve the problem in my real code :(
          – chranmat
          Nov 12 at 20:47




          Ref comment on previous answer. I can see I did a typo there and that my example actually works. This does not solve the problem in my real code :(
          – chranmat
          Nov 12 at 20:47












          @chranmat No worries. Can you post your actual code please?
          – War10ck
          Nov 12 at 20:48




          @chranmat No worries. Can you post your actual code please?
          – War10ck
          Nov 12 at 20:48












          pastebin.com/XpcWUtrv
          – chranmat
          Nov 12 at 21:06




          pastebin.com/XpcWUtrv
          – chranmat
          Nov 12 at 21:06


















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid …



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.





          Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


          Please pay close attention to the following guidance:


          • Please be sure to answer the question. Provide details and share your research!

          But avoid …



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53269520%2fcallback-executed-too-early%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          -

          Popular posts from this blog

          Bressuire

          Image
          Subprefecture and commune in Nouvelle-Aquitaine, France Bressuire Subprefecture and commune Chateau de Bressuire and the Eglise Notre-Dame Coat of arms Location of Bressuire Bressuire Show map of France Bressuire Show map of Nouvelle-Aquitaine Coordinates: 46°50′27″N 0°29′14″W  /  46.8408°N 0.4872°W  / 46.8408; -0.4872 Coordinates: 46°50′27″N 0°29′14″W  /  46.8408°N 0.4872°W  / 46.8408; -0.4872 Country France Region Nouvelle-Aquitaine Department Deux-Sèvres Arrondissement Bressuire Canton Bressuire Government  • Mayor .mw-parser-output .nobold{font-weight:normal} (2014–20) Jean Michel Bernier Area 1 180.59 km 2 (69.73 sq mi) Population (2014) 2 19,300  • Density 110/km 2 (280/sq mi) Time zone UTC+01:00 (CET)  • Summer (DST) UTC+02:00 (CEST) INSEE/Postal code 79049 /79300 Elevation 98–236 m (322–774 ft) (avg. 173 m or 568 ft) 1 French Land Register data, which exclude...
          Read more

          Vorschmack

          Image
          Vorschmack Ukrainian Jewish-style vorschmack served on rye bread Course Hors d'oeuvre Region or state Eastern Europe Associated national cuisine Ashkenazi Jewish, Finnish, German, Ukrainian, Polish, Russian Main ingredients Ground meat and/or fish Cookbook: Vorschmack   Media: Vorschmack Vorschmack or forshmak (Yiddish: פֿאָרשמאַק ‎, from archaic German Vorschmack , "foretaste" [1] or "appetizer" [2] ) is an originally East European dish made of salty minced fish or meat. Different variants of this dish are especially common in Ashkenazi Jewish and Finnish cuisine. Some varieties are also known in Russian and Polish cuisine. Contents 1 In Jewish cuisine 2 In Russian cuisine 3 In Polish cuisine 4 In Finnish cuisine 5 See also 6 References In Jewish cuisine According to Gil Marks, the German name points to the possible Germanic origin of this dish. [1] William Pokhlyobkin descr...
          Read more

          Quarantine

          Image
          For other uses, see Quarantine (disambiguation). Signal flag "Lima" called the "Yellow Jack" which when flown in harbor means ship is under quarantine. A simple yellow flag (also called the "Yellow Jack") had historically been used to signal quarantine (it stands for Q among signal flags), but now indicates the opposite, as a signal of a ship free of disease that requests boarding and inspection. A quarantine is used to separate and restrict the movement of people; it is 'a restraint upon the activities or communication of persons or the transport of goods designed to prevent the spread of disease or pests', for a certain period of time. [1] This is often used in connection to disease and illness, such as those who may possibly have been exposed to a communicable disease. [2] The term is often erroneously used to mean medical isolation, which is "to separate ill persons who have a communicable disease from those who are healthy...
          Read more