Angular http get return undefined












0














I have a express router get



var express = require('express');
var router = express.Router();
var mongoose = require('mongoose');
var Stats = require('../models/Stats.js');

/* GET ALL STATS */
router.get('/', function(req, res, next) {
Stats.find(function (err, products) {
if (err) return next(err);
res.json(products);
});
});


Also api



 getAll(){
this.http.get('/main').subscribe(data => {
console.log(data);
return data;
});
}


And i am using it in component



show(){
console.log(this.api.getAll());
}


Problem is that when i log data in api getAll() data is returned well, but if i log data in component i have undefined.










share|improve this question





























    0














    I have a express router get



    var express = require('express');
    var router = express.Router();
    var mongoose = require('mongoose');
    var Stats = require('../models/Stats.js');

    /* GET ALL STATS */
    router.get('/', function(req, res, next) {
    Stats.find(function (err, products) {
    if (err) return next(err);
    res.json(products);
    });
    });


    Also api



     getAll(){
    this.http.get('/main').subscribe(data => {
    console.log(data);
    return data;
    });
    }


    And i am using it in component



    show(){
    console.log(this.api.getAll());
    }


    Problem is that when i log data in api getAll() data is returned well, but if i log data in component i have undefined.










    share|improve this question



























      0












      0








      0







      I have a express router get



      var express = require('express');
      var router = express.Router();
      var mongoose = require('mongoose');
      var Stats = require('../models/Stats.js');

      /* GET ALL STATS */
      router.get('/', function(req, res, next) {
      Stats.find(function (err, products) {
      if (err) return next(err);
      res.json(products);
      });
      });


      Also api



       getAll(){
      this.http.get('/main').subscribe(data => {
      console.log(data);
      return data;
      });
      }


      And i am using it in component



      show(){
      console.log(this.api.getAll());
      }


      Problem is that when i log data in api getAll() data is returned well, but if i log data in component i have undefined.










      share|improve this question















      I have a express router get



      var express = require('express');
      var router = express.Router();
      var mongoose = require('mongoose');
      var Stats = require('../models/Stats.js');

      /* GET ALL STATS */
      router.get('/', function(req, res, next) {
      Stats.find(function (err, products) {
      if (err) return next(err);
      res.json(products);
      });
      });


      Also api



       getAll(){
      this.http.get('/main').subscribe(data => {
      console.log(data);
      return data;
      });
      }


      And i am using it in component



      show(){
      console.log(this.api.getAll());
      }


      Problem is that when i log data in api getAll() data is returned well, but if i log data in component i have undefined.







      angular






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited Nov 12 at 21:42









      Neil Lunn

      96.8k22170181




      96.8k22170181










      asked Nov 12 at 13:28









      devio95

      83




      83
























          3 Answers
          3






          active

          oldest

          votes


















          0














          Your service or API within Angular should just be calling the backend service and not subscribing via in the service itself but rather in the component.



          Service:



          getAll(){
          return this.http.get('/main');
          }


          Component:



          this.service.getAll().subscribe((data)=> {
          // Your Data
          },error => {
          console.log('error: ', error)
          });





          share|improve this answer































            1














            In getAll() you should return the observable:



            getAll(){
            return this.http.get('/main');
            }


            And then in where you call the function you subscribe to the observable:



            show(){
            this.api.getAll().subscribe((data) => {
            // Here you can do what you want with the data.
            console.log(data)
            })
            }





            share|improve this answer































              0














              Your service should return, change your service to



              getAll(){
              return this.http.get('/main').subscribe(data => {
              console.log(data);
              return data;
              });
              }


              And it is better to subscribe in the component part not while declaring your services.






              share|improve this answer























              • Now the show() function is only going to log the observable returned by getAll().
                – mika
                Nov 12 at 13:40










              • @mika what ?? you're wrong ! it is already subscribed there why would it return observable ??, reread what i'd written.
                – selem mn
                Nov 12 at 15:26











              Your Answer






              StackExchange.ifUsing("editor", function () {
              StackExchange.using("externalEditor", function () {
              StackExchange.using("snippets", function () {
              StackExchange.snippets.init();
              });
              });
              }, "code-snippets");

              StackExchange.ready(function() {
              var channelOptions = {
              tags: "".split(" "),
              id: "1"
              };
              initTagRenderer("".split(" "), "".split(" "), channelOptions);

              StackExchange.using("externalEditor", function() {
              // Have to fire editor after snippets, if snippets enabled
              if (StackExchange.settings.snippets.snippetsEnabled) {
              StackExchange.using("snippets", function() {
              createEditor();
              });
              }
              else {
              createEditor();
              }
              });

              function createEditor() {
              StackExchange.prepareEditor({
              heartbeatType: 'answer',
              autoActivateHeartbeat: false,
              convertImagesToLinks: true,
              noModals: true,
              showLowRepImageUploadWarning: true,
              reputationToPostImages: 10,
              bindNavPrevention: true,
              postfix: "",
              imageUploader: {
              brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
              contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
              allowUrls: true
              },
              onDemand: true,
              discardSelector: ".discard-answer"
              ,immediatelyShowMarkdownHelp:true
              });


              }
              });














              draft saved

              draft discarded


















              StackExchange.ready(
              function () {
              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53263201%2fangular-http-get-return-undefined%23new-answer', 'question_page');
              }
              );

              Post as a guest















              Required, but never shown

























              3 Answers
              3






              active

              oldest

              votes








              3 Answers
              3






              active

              oldest

              votes









              active

              oldest

              votes






              active

              oldest

              votes









              0














              Your service or API within Angular should just be calling the backend service and not subscribing via in the service itself but rather in the component.



              Service:



              getAll(){
              return this.http.get('/main');
              }


              Component:



              this.service.getAll().subscribe((data)=> {
              // Your Data
              },error => {
              console.log('error: ', error)
              });





              share|improve this answer




























                0














                Your service or API within Angular should just be calling the backend service and not subscribing via in the service itself but rather in the component.



                Service:



                getAll(){
                return this.http.get('/main');
                }


                Component:



                this.service.getAll().subscribe((data)=> {
                // Your Data
                },error => {
                console.log('error: ', error)
                });





                share|improve this answer


























                  0












                  0








                  0






                  Your service or API within Angular should just be calling the backend service and not subscribing via in the service itself but rather in the component.



                  Service:



                  getAll(){
                  return this.http.get('/main');
                  }


                  Component:



                  this.service.getAll().subscribe((data)=> {
                  // Your Data
                  },error => {
                  console.log('error: ', error)
                  });





                  share|improve this answer














                  Your service or API within Angular should just be calling the backend service and not subscribing via in the service itself but rather in the component.



                  Service:



                  getAll(){
                  return this.http.get('/main');
                  }


                  Component:



                  this.service.getAll().subscribe((data)=> {
                  // Your Data
                  },error => {
                  console.log('error: ', error)
                  });






                  share|improve this answer














                  share|improve this answer



                  share|improve this answer








                  edited Nov 12 at 13:53









                  mika

                  23714




                  23714










                  answered Nov 12 at 13:49









                  Taranjit Kang

                  7841519




                  7841519

























                      1














                      In getAll() you should return the observable:



                      getAll(){
                      return this.http.get('/main');
                      }


                      And then in where you call the function you subscribe to the observable:



                      show(){
                      this.api.getAll().subscribe((data) => {
                      // Here you can do what you want with the data.
                      console.log(data)
                      })
                      }





                      share|improve this answer




























                        1














                        In getAll() you should return the observable:



                        getAll(){
                        return this.http.get('/main');
                        }


                        And then in where you call the function you subscribe to the observable:



                        show(){
                        this.api.getAll().subscribe((data) => {
                        // Here you can do what you want with the data.
                        console.log(data)
                        })
                        }





                        share|improve this answer


























                          1












                          1








                          1






                          In getAll() you should return the observable:



                          getAll(){
                          return this.http.get('/main');
                          }


                          And then in where you call the function you subscribe to the observable:



                          show(){
                          this.api.getAll().subscribe((data) => {
                          // Here you can do what you want with the data.
                          console.log(data)
                          })
                          }





                          share|improve this answer














                          In getAll() you should return the observable:



                          getAll(){
                          return this.http.get('/main');
                          }


                          And then in where you call the function you subscribe to the observable:



                          show(){
                          this.api.getAll().subscribe((data) => {
                          // Here you can do what you want with the data.
                          console.log(data)
                          })
                          }






                          share|improve this answer














                          share|improve this answer



                          share|improve this answer








                          edited Nov 12 at 13:44

























                          answered Nov 12 at 13:38









                          mika

                          23714




                          23714























                              0














                              Your service should return, change your service to



                              getAll(){
                              return this.http.get('/main').subscribe(data => {
                              console.log(data);
                              return data;
                              });
                              }


                              And it is better to subscribe in the component part not while declaring your services.






                              share|improve this answer























                              • Now the show() function is only going to log the observable returned by getAll().
                                – mika
                                Nov 12 at 13:40










                              • @mika what ?? you're wrong ! it is already subscribed there why would it return observable ??, reread what i'd written.
                                – selem mn
                                Nov 12 at 15:26
















                              0














                              Your service should return, change your service to



                              getAll(){
                              return this.http.get('/main').subscribe(data => {
                              console.log(data);
                              return data;
                              });
                              }


                              And it is better to subscribe in the component part not while declaring your services.






                              share|improve this answer























                              • Now the show() function is only going to log the observable returned by getAll().
                                – mika
                                Nov 12 at 13:40










                              • @mika what ?? you're wrong ! it is already subscribed there why would it return observable ??, reread what i'd written.
                                – selem mn
                                Nov 12 at 15:26














                              0












                              0








                              0






                              Your service should return, change your service to



                              getAll(){
                              return this.http.get('/main').subscribe(data => {
                              console.log(data);
                              return data;
                              });
                              }


                              And it is better to subscribe in the component part not while declaring your services.






                              share|improve this answer














                              Your service should return, change your service to



                              getAll(){
                              return this.http.get('/main').subscribe(data => {
                              console.log(data);
                              return data;
                              });
                              }


                              And it is better to subscribe in the component part not while declaring your services.







                              share|improve this answer














                              share|improve this answer



                              share|improve this answer








                              edited Nov 12 at 13:37

























                              answered Nov 12 at 13:29









                              selem mn

                              4,67541939




                              4,67541939












                              • Now the show() function is only going to log the observable returned by getAll().
                                – mika
                                Nov 12 at 13:40










                              • @mika what ?? you're wrong ! it is already subscribed there why would it return observable ??, reread what i'd written.
                                – selem mn
                                Nov 12 at 15:26


















                              • Now the show() function is only going to log the observable returned by getAll().
                                – mika
                                Nov 12 at 13:40










                              • @mika what ?? you're wrong ! it is already subscribed there why would it return observable ??, reread what i'd written.
                                – selem mn
                                Nov 12 at 15:26
















                              Now the show() function is only going to log the observable returned by getAll().
                              – mika
                              Nov 12 at 13:40




                              Now the show() function is only going to log the observable returned by getAll().
                              – mika
                              Nov 12 at 13:40












                              @mika what ?? you're wrong ! it is already subscribed there why would it return observable ??, reread what i'd written.
                              – selem mn
                              Nov 12 at 15:26




                              @mika what ?? you're wrong ! it is already subscribed there why would it return observable ??, reread what i'd written.
                              – selem mn
                              Nov 12 at 15:26


















                              draft saved

                              draft discarded




















































                              Thanks for contributing an answer to Stack Overflow!


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid



                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.


                              To learn more, see our tips on writing great answers.





                              Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                              Please pay close attention to the following guidance:


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid



                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.


                              To learn more, see our tips on writing great answers.




                              draft saved


                              draft discarded














                              StackExchange.ready(
                              function () {
                              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53263201%2fangular-http-get-return-undefined%23new-answer', 'question_page');
                              }
                              );

                              Post as a guest















                              Required, but never shown





















































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown

































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown







                              Popular posts from this blog

                              Bressuire

                              Vorschmack

                              Quarantine