Vfrdtyky

I've been racking my brain over this for hours :-/

I'm trying to incorporate Express Validator checks before Passport authenticate in order for a new user to signup/register.

From reading online and a ton of tutorials I understand Passport needs to be used as custom callback (http://www.passportjs.org/docs/authenticate/) if valdidate checks are to be used first. However I've tried many different options and either the checks work and passport authenticates with no new user added to the mongodb database, or I can register a new user email despite that user email already existing.

Any help is much appreciated! Please let me know if you need more code/info from me. Thanks in advance!

User.js file

var mongoose = require('mongoose');

var bcrypt   = require('bcrypt-nodejs');

var userSchema = mongoose.Schema({



 local            : {

    email        : String,

    password     : String,

    fname        : String,

    lname        : String,

    role         : String,

 }



});



 // generating a hash =============

userSchema.methods.generateHash = function(password) {

return bcrypt.hashSync(password, bcrypt.genSaltSync(12), null);

};



// checking if password is valid

userSchema.methods.validPassword = function(password) {

return bcrypt.compareSync(password, this.local.password);

};







module.exports = mongoose.model('User', userSchema);

Passport.js file

passport.use('local-signup', new LocalStrategy({

    // by default, local strategy uses username and password, we will override with email

    usernameField : 'email',

    passwordField : 'password',

    passReqToCallback : true },





function(req, password, email, done) {

            //specify new variables (As well as password & email already captured in function)

                    var fname = req.body.fname;

                    var lname = req.body.lname;

                    var role = req.body.role;





    User.findOne({ 'local.email' :  email }, function(err, user, req) {

        // if there are any errors, return the error

        if (err)

            return done(err);



        // check to see if theres already a user with that email

        if (user) {

            return done(null, false, req.flash('signupMessage', 'That email is already taken.'));

        } else {



            // if there is no user with that email

            // create the user

            var newUser            = new User();



            // set the user's local credentials

            newUser.local.email    = email;

            newUser.local.password = newUser.generateHash(password);

            newUser.local.fname     = fname;

            newUser.local.lname     = lname;

            newUser.local.role     = role;

            // save the user

            newUser.save(function(err) {

                if (err)

                    throw err;

                return done(null, newUser);

            });

        }

    });

}));

Routes.js file

 app.post('/signup',



    check('email')

           .not().isEmpty().withMessage('Please specify an email.')

           .isEmail().withMessage('Incorrect email format.'),

    check('password')

           .not().isEmpty().withMessage('Please specify a password.')

           .matches(/^(?=.*d)(?=.*[a-z])(?=.*[A-Z])(?!.* )(?=.*[^a-zA-Z0-9]).{8,}$/, 'i').withMessage('Password must include 1 uppercase character, 1 number and 1 special character')

           .isLength({min: 8, max: 100}).withMessage('Password must be at least 8 characters in length.'),

    check('fname')

            .not().isEmpty().withMessage('Please enter your first name.'),

    check('lname')

            .not().isEmpty().withMessage('Please enter your last name.'),

    check('role')

            .not().isEmpty().withMessage('Please state your role.'),



 function(req, res, next) {

         var errors = validationResult(req);

             if (!errors.isEmpty()) {

             return res.render('signup.html', {message: errors.array()[0].msg});

          } else {



passport.authenticate('local-signup', function(err, user, info) {

                    if (err) { return next(err); }

                    if (!user) { return res.redirect('/signup'); }

                    req.logIn(user, function(err) {

                          if (err) { return next(err); }

                            return res.redirect('/profile');

                    });

            })(req, res, next);

       };

    });