Filereader.Onload fired too early











up vote
0
down vote

favorite












I try to read files uploaded by a input type file (multiple). The code is the following:



$(document).ready(function() {
$('#convert').on('click', function() {
var files=$('#files')[0].files;
if (!files) return;
for (var i=0; i<files.length; i++) {
var file=files[i];
fr = new FileReader();
fr.onload = (function(received) {
var note=$(fr.result);
});
fr.readAsText(file);
}
});
});


Now my problem is:
The "onload" - function is called even before the file is loaded. note never has any content. But when I put a breakpoint just before the note - line and wait a while, note gets the content.



So it seems, the onload()-event is called too early. What can I do about that?



(Browser is Chrome)










share|improve this question


























    up vote
    0
    down vote

    favorite












    I try to read files uploaded by a input type file (multiple). The code is the following:



    $(document).ready(function() {
    $('#convert').on('click', function() {
    var files=$('#files')[0].files;
    if (!files) return;
    for (var i=0; i<files.length; i++) {
    var file=files[i];
    fr = new FileReader();
    fr.onload = (function(received) {
    var note=$(fr.result);
    });
    fr.readAsText(file);
    }
    });
    });


    Now my problem is:
    The "onload" - function is called even before the file is loaded. note never has any content. But when I put a breakpoint just before the note - line and wait a while, note gets the content.



    So it seems, the onload()-event is called too early. What can I do about that?



    (Browser is Chrome)










    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I try to read files uploaded by a input type file (multiple). The code is the following:



      $(document).ready(function() {
      $('#convert').on('click', function() {
      var files=$('#files')[0].files;
      if (!files) return;
      for (var i=0; i<files.length; i++) {
      var file=files[i];
      fr = new FileReader();
      fr.onload = (function(received) {
      var note=$(fr.result);
      });
      fr.readAsText(file);
      }
      });
      });


      Now my problem is:
      The "onload" - function is called even before the file is loaded. note never has any content. But when I put a breakpoint just before the note - line and wait a while, note gets the content.



      So it seems, the onload()-event is called too early. What can I do about that?



      (Browser is Chrome)










      share|improve this question













      I try to read files uploaded by a input type file (multiple). The code is the following:



      $(document).ready(function() {
      $('#convert').on('click', function() {
      var files=$('#files')[0].files;
      if (!files) return;
      for (var i=0; i<files.length; i++) {
      var file=files[i];
      fr = new FileReader();
      fr.onload = (function(received) {
      var note=$(fr.result);
      });
      fr.readAsText(file);
      }
      });
      });


      Now my problem is:
      The "onload" - function is called even before the file is loaded. note never has any content. But when I put a breakpoint just before the note - line and wait a while, note gets the content.



      So it seems, the onload()-event is called too early. What can I do about that?



      (Browser is Chrome)







      javascript filereader






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 11 at 13:39









      Ole Albers

      3,844635102




      3,844635102
























          2 Answers
          2






          active

          oldest

          votes

















          up vote
          1
          down vote













          I replaced fr.result by this.result:



          fr.onload = (function() {      
          var note=$(this.result);
          });


          That did the trick






          share|improve this answer




























            up vote
            0
            down vote













            You are making fr a global variable and at the time the onload fires it will be a different object than you expect due to the loop



            Try wrapping it in an IIFE to create a closure and making fr a local variable



            for (var i = 0; i < files.length; i++) {  
            (function(file) {
            var fr = new FileReader();
            fr.onload = function(received) {
            var note = $(fr.result);// not sure what intent is here
            };
            fr.readAsText(file);
            })(files[i])
            }





            share|improve this answer























              Your Answer






              StackExchange.ifUsing("editor", function () {
              StackExchange.using("externalEditor", function () {
              StackExchange.using("snippets", function () {
              StackExchange.snippets.init();
              });
              });
              }, "code-snippets");

              StackExchange.ready(function() {
              var channelOptions = {
              tags: "".split(" "),
              id: "1"
              };
              initTagRenderer("".split(" "), "".split(" "), channelOptions);

              StackExchange.using("externalEditor", function() {
              // Have to fire editor after snippets, if snippets enabled
              if (StackExchange.settings.snippets.snippetsEnabled) {
              StackExchange.using("snippets", function() {
              createEditor();
              });
              }
              else {
              createEditor();
              }
              });

              function createEditor() {
              StackExchange.prepareEditor({
              heartbeatType: 'answer',
              convertImagesToLinks: true,
              noModals: true,
              showLowRepImageUploadWarning: true,
              reputationToPostImages: 10,
              bindNavPrevention: true,
              postfix: "",
              imageUploader: {
              brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
              contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
              allowUrls: true
              },
              onDemand: true,
              discardSelector: ".discard-answer"
              ,immediatelyShowMarkdownHelp:true
              });


              }
              });














              draft saved

              draft discarded


















              StackExchange.ready(
              function () {
              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53249315%2ffilereader-onload-fired-too-early%23new-answer', 'question_page');
              }
              );

              Post as a guest















              Required, but never shown

























              2 Answers
              2






              active

              oldest

              votes








              2 Answers
              2






              active

              oldest

              votes









              active

              oldest

              votes






              active

              oldest

              votes








              up vote
              1
              down vote













              I replaced fr.result by this.result:



              fr.onload = (function() {      
              var note=$(this.result);
              });


              That did the trick






              share|improve this answer

























                up vote
                1
                down vote













                I replaced fr.result by this.result:



                fr.onload = (function() {      
                var note=$(this.result);
                });


                That did the trick






                share|improve this answer























                  up vote
                  1
                  down vote










                  up vote
                  1
                  down vote









                  I replaced fr.result by this.result:



                  fr.onload = (function() {      
                  var note=$(this.result);
                  });


                  That did the trick






                  share|improve this answer












                  I replaced fr.result by this.result:



                  fr.onload = (function() {      
                  var note=$(this.result);
                  });


                  That did the trick







                  share|improve this answer












                  share|improve this answer



                  share|improve this answer










                  answered Nov 11 at 14:39









                  Ole Albers

                  3,844635102




                  3,844635102
























                      up vote
                      0
                      down vote













                      You are making fr a global variable and at the time the onload fires it will be a different object than you expect due to the loop



                      Try wrapping it in an IIFE to create a closure and making fr a local variable



                      for (var i = 0; i < files.length; i++) {  
                      (function(file) {
                      var fr = new FileReader();
                      fr.onload = function(received) {
                      var note = $(fr.result);// not sure what intent is here
                      };
                      fr.readAsText(file);
                      })(files[i])
                      }





                      share|improve this answer



























                        up vote
                        0
                        down vote













                        You are making fr a global variable and at the time the onload fires it will be a different object than you expect due to the loop



                        Try wrapping it in an IIFE to create a closure and making fr a local variable



                        for (var i = 0; i < files.length; i++) {  
                        (function(file) {
                        var fr = new FileReader();
                        fr.onload = function(received) {
                        var note = $(fr.result);// not sure what intent is here
                        };
                        fr.readAsText(file);
                        })(files[i])
                        }





                        share|improve this answer

























                          up vote
                          0
                          down vote










                          up vote
                          0
                          down vote









                          You are making fr a global variable and at the time the onload fires it will be a different object than you expect due to the loop



                          Try wrapping it in an IIFE to create a closure and making fr a local variable



                          for (var i = 0; i < files.length; i++) {  
                          (function(file) {
                          var fr = new FileReader();
                          fr.onload = function(received) {
                          var note = $(fr.result);// not sure what intent is here
                          };
                          fr.readAsText(file);
                          })(files[i])
                          }





                          share|improve this answer














                          You are making fr a global variable and at the time the onload fires it will be a different object than you expect due to the loop



                          Try wrapping it in an IIFE to create a closure and making fr a local variable



                          for (var i = 0; i < files.length; i++) {  
                          (function(file) {
                          var fr = new FileReader();
                          fr.onload = function(received) {
                          var note = $(fr.result);// not sure what intent is here
                          };
                          fr.readAsText(file);
                          })(files[i])
                          }






                          share|improve this answer














                          share|improve this answer



                          share|improve this answer








                          edited Nov 11 at 14:14

























                          answered Nov 11 at 13:53









                          charlietfl

                          138k1286118




                          138k1286118






























                              draft saved

                              draft discarded




















































                              Thanks for contributing an answer to Stack Overflow!


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid



                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.


                              To learn more, see our tips on writing great answers.





                              Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


                              Please pay close attention to the following guidance:


                              • Please be sure to answer the question. Provide details and share your research!

                              But avoid



                              • Asking for help, clarification, or responding to other answers.

                              • Making statements based on opinion; back them up with references or personal experience.


                              To learn more, see our tips on writing great answers.




                              draft saved


                              draft discarded














                              StackExchange.ready(
                              function () {
                              StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53249315%2ffilereader-onload-fired-too-early%23new-answer', 'question_page');
                              }
                              );

                              Post as a guest















                              Required, but never shown





















































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown

































                              Required, but never shown














                              Required, but never shown












                              Required, but never shown







                              Required, but never shown







                              Popular posts from this blog

                              List item for chat from Array inside array React Native

                              Thiostrepton

                              Caerphilly