Vfrdtyky

I am reading a message from the socket using this tcp_read function:

    ssize_t tcp_read(int fd, void *buf, size_t count)

    {

        size_t nread = 0;



        while (count > 0) {

        int r = read(fd, buf, count);

        if (r < 0 && errno == EINTR)

            continue;

        if (r < 0)

            return r;

        if (r == 0)

            return nread;

        buf = (unsigned char *) buf + r;

        count -= r;

    nread += r;

    }



    return nread;

}

In the server.c file I am creating a guessing the word game, I am reading the message from the user using this tcp_read function which is close to the real read().

The user will input something like: "L: somewordrn" and I am reading this in the following way:

   char read[strlen(token2)+5];

   char *token2 = "someword"

   int n = tcp_read(cfd, read, strlen(token2)+5);

   read[n] = '';



   char *s;

   size_t len = strlen(read);

   s = malloc(len);

   strcpy(s, read+3);  //to cut 'R: '

   s[len - 4] = 0; 

   tcp_write(cfd, s, strlen(s));



   if(strcmp(token2, read) == 0)

   {

         tcp_write(cfd, beg_o, strlen(beg_o)); 

   }else

   {

         tcp_write(cfd, beg_f, strlen(beg_f));

   }

token2 is the word that the user is supposed to guess. and beg_o and beg_f are just some printing of 'Congratulation' and 'You failed'.

I did the strlen(token2) + 5, since the token2 is the word that the user should guess + 5 characters for 'R' ':' ' ' 'r' 'n', since those 5 characters are always the same every user inputs like this, only someword is what is dynamic.

In the first iteration its working, but then when the function is called again it is not working anymore (Because the second part of the code is in a big loop)

But I cannot understand why this is not working, sometimes it works sometimes it fails for example the user inputs "L: somewordrn" and the read in my function is not someword but sometimes is somew sometimes is just so. It is behaving weird.

I'm surprised that compiles, just looking at it. The dynamic array dims are an extension, which you should probably avoid -- just do char read[1024] or something. (Really you should use a #define for that.) But in any case, token2 is not even defined on the first line, so I don't see how the dynamic array dim can be evaluated.

Once you get over that, use a debugger. Step through line by line examining variables until you see where it's gone wrong.

Don't return when r == 0. Wait until you reach count and return only then.