How golang gin stop handler function immediately if connection is lost
0
I am using gin-gonic/gin to write my server.
It seems even if the connection is lost, the handler function is still running. For example, if I visit http://127.0.0.1:8080/ping and close the browser suddenly, the screen will continue to print all the numbers.
package main
import (
"github.com/gin-gonic/gin"
"log"
"time"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
for i := 1; i < 15; i++ {
time.Sleep(time.Second * 1)
log.Println(i)
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
How should I stop handler function immediately (e.g. to reduce server load)?
go gin gin-gonic
asked Nov 15 '18 at 15:49
qing6010qing6010
5625
add a comment |
0
I am using gin-gonic/gin to write my server.
It seems even if the connection is lost, the handler function is still running. For example, if I visit http://127.0.0.1:8080/ping and close the browser suddenly, the screen will continue to print all the numbers.
package main
import (
"github.com/gin-gonic/gin"
"log"
"time"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
for i := 1; i < 15; i++ {
time.Sleep(time.Second * 1)
log.Println(i)
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
How should I stop handler function immediately (e.g. to reduce server load)?
go gin gin-gonic
asked Nov 15 '18 at 15:49
qing6010qing6010
5625
add a comment |
0
0
0
I am using gin-gonic/gin to write my server.
It seems even if the connection is lost, the handler function is still running. For example, if I visit http://127.0.0.1:8080/ping and close the browser suddenly, the screen will continue to print all the numbers.
package main
import (
"github.com/gin-gonic/gin"
"log"
"time"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
for i := 1; i < 15; i++ {
time.Sleep(time.Second * 1)
log.Println(i)
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
How should I stop handler function immediately (e.g. to reduce server load)?
go gin gin-gonic
asked Nov 15 '18 at 15:49
qing6010qing6010
5625
I am using gin-gonic/gin to write my server.
It seems even if the connection is lost, the handler function is still running. For example, if I visit http://127.0.0.1:8080/ping and close the browser suddenly, the screen will continue to print all the numbers.
package main
import (
"github.com/gin-gonic/gin"
"log"
"time"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
for i := 1; i < 15; i++ {
time.Sleep(time.Second * 1)
log.Println(i)
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
How should I stop handler function immediately (e.g. to reduce server load)?
go gin gin-gonic
go gin gin-gonic
asked Nov 15 '18 at 15:49
qing6010qing6010
5625
asked Nov 15 '18 at 15:49
qing6010qing6010
5625
asked Nov 15 '18 at 15:49
qing6010qing6010
5625
asked Nov 15 '18 at 15:49
qing6010qing6010
5625
asked Nov 15 '18 at 15:49
qing6010qing6010
5625
5625
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
1
The request context is canceled when the client disconnects, so simply check if c.Done() is ready to receive:
package main
import (
"log"
"time"
"github.com/gin-gonic/gin"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
t := time.NewTicker(1 * time.Second)
defer t.Stop()
for i := 1; i < 15; i++ {
select {
case <-t.C:
log.Println(i)
case <-c.Request.Context().Done():
// client gave up
return
}
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
answered Nov 15 '18 at 16:06
PeterPeter
16.4k42532
I tested the code and it still prints out all the numbers though
– qing6010
Nov 16 '18 at 5:54
OK... it works by replacing "c.Done()" with "c.Request.Context().Done()" as from github.com/gin-gonic/gin/issues/1452.
– qing6010
Nov 16 '18 at 6:13
Sorry about that. I just assumed that gin's context behaves like the standard request context. I have updated the answer.
– Peter
Nov 16 '18 at 8:13
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53323110%2fhow-golang-gin-stop-handler-function-immediately-if-connection-is-lost%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
1
The request context is canceled when the client disconnects, so simply check if c.Done() is ready to receive:
package main
import (
"log"
"time"
"github.com/gin-gonic/gin"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
t := time.NewTicker(1 * time.Second)
defer t.Stop()
for i := 1; i < 15; i++ {
select {
case <-t.C:
log.Println(i)
case <-c.Request.Context().Done():
// client gave up
return
}
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
answered Nov 15 '18 at 16:06
PeterPeter
16.4k42532
I tested the code and it still prints out all the numbers though
– qing6010
Nov 16 '18 at 5:54
OK... it works by replacing "c.Done()" with "c.Request.Context().Done()" as from github.com/gin-gonic/gin/issues/1452.
– qing6010
Nov 16 '18 at 6:13
Sorry about that. I just assumed that gin's context behaves like the standard request context. I have updated the answer.
– Peter
Nov 16 '18 at 8:13
add a comment |
1
The request context is canceled when the client disconnects, so simply check if c.Done() is ready to receive:
package main
import (
"log"
"time"
"github.com/gin-gonic/gin"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
t := time.NewTicker(1 * time.Second)
defer t.Stop()
for i := 1; i < 15; i++ {
select {
case <-t.C:
log.Println(i)
case <-c.Request.Context().Done():
// client gave up
return
}
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
answered Nov 15 '18 at 16:06
PeterPeter
16.4k42532
I tested the code and it still prints out all the numbers though
– qing6010
Nov 16 '18 at 5:54
OK... it works by replacing "c.Done()" with "c.Request.Context().Done()" as from github.com/gin-gonic/gin/issues/1452.
– qing6010
Nov 16 '18 at 6:13
Sorry about that. I just assumed that gin's context behaves like the standard request context. I have updated the answer.
– Peter
Nov 16 '18 at 8:13
add a comment |
1
1
1
The request context is canceled when the client disconnects, so simply check if c.Done() is ready to receive:
package main
import (
"log"
"time"
"github.com/gin-gonic/gin"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
t := time.NewTicker(1 * time.Second)
defer t.Stop()
for i := 1; i < 15; i++ {
select {
case <-t.C:
log.Println(i)
case <-c.Request.Context().Done():
// client gave up
return
}
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
answered Nov 15 '18 at 16:06
PeterPeter
16.4k42532
The request context is canceled when the client disconnects, so simply check if c.Done() is ready to receive:
package main
import (
"log"
"time"
"github.com/gin-gonic/gin"
)
func main() {
r := gin.Default()
r.GET("/ping", func(c *gin.Context) {
t := time.NewTicker(1 * time.Second)
defer t.Stop()
for i := 1; i < 15; i++ {
select {
case <-t.C:
log.Println(i)
case <-c.Request.Context().Done():
// client gave up
return
}
}
c.JSON(200, gin.H{
"message": "pong",
})
})
r.Run("127.0.0.1:8080")
}
answered Nov 15 '18 at 16:06
PeterPeter
16.4k42532
edited Nov 16 '18 at 8:11
answered Nov 15 '18 at 16:06
PeterPeter
16.4k42532
answered Nov 15 '18 at 16:06
PeterPeter
16.4k42532
answered Nov 15 '18 at 16:06
PeterPeter
16.4k42532
16.4k42532
I tested the code and it still prints out all the numbers though
– qing6010
Nov 16 '18 at 5:54
OK... it works by replacing "c.Done()" with "c.Request.Context().Done()" as from github.com/gin-gonic/gin/issues/1452.
– qing6010
Nov 16 '18 at 6:13
Sorry about that. I just assumed that gin's context behaves like the standard request context. I have updated the answer.
– Peter
Nov 16 '18 at 8:13
add a comment |
I tested the code and it still prints out all the numbers though
– qing6010
Nov 16 '18 at 5:54
OK... it works by replacing "c.Done()" with "c.Request.Context().Done()" as from github.com/gin-gonic/gin/issues/1452.
– qing6010
Nov 16 '18 at 6:13
Sorry about that. I just assumed that gin's context behaves like the standard request context. I have updated the answer.
– Peter
Nov 16 '18 at 8:13
I tested the code and it still prints out all the numbers though
– qing6010
Nov 16 '18 at 5:54
I tested the code and it still prints out all the numbers though
– qing6010
Nov 16 '18 at 5:54
OK... it works by replacing "c.Done()" with "c.Request.Context().Done()" as from github.com/gin-gonic/gin/issues/1452.
– qing6010
Nov 16 '18 at 6:13
OK... it works by replacing "c.Done()" with "c.Request.Context().Done()" as from github.com/gin-gonic/gin/issues/1452.
– qing6010
Nov 16 '18 at 6:13
Sorry about that. I just assumed that gin's context behaves like the standard request context. I have updated the answer.
– Peter
Nov 16 '18 at 8:13
Sorry about that. I just assumed that gin's context behaves like the standard request context. I have updated the answer.
– Peter
Nov 16 '18 at 8:13
add a comment |
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53323110%2fhow-golang-gin-stop-handler-function-immediately-if-connection-is-lost%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
