How to validate view model with collection of abstract items
I have an abstract class and few child classes and I'm using abstract model binder from this answer to bind them into specific class.
public abstract class BaseProductViewModel
{
public int Id { get; set; }
public string Type { get => GetType().FullName; }
public int DealerId { get; set; }
}
public class MortgageViewModel : BaseProductViewModel
{
// other properties with validation attributes
}
public class InsuranceViewModel : BaseProductViewModel
{
// other properties with validation attributes
}
My edit viewmodel has collection of these classes and some other properties.
public class EditFormViewModel
{
[Required]
public string FirstName { get; set; }
[Required]
public string LastName { get; set; }
// other properties with validation attributes
public IList<BaseProductViewModel> Products { get; set; }
}
Mapping works fine but validation of the Products list is a problem. I also added validation into BindModelAsync method:
using (bindingContext.EnterNestedScope(metadata, bindingContext.FieldName, bindingContext.ModelName, model: null))
{
await binder.BindModelAsync(bindingContext);
result = bindingContext.Result;
var validationResult = from prop in TypeDescriptor.GetProperties(result.Model).Cast<PropertyDescriptor>()
from attribute in prop.Attributes.OfType<ValidationAttribute>()
where !attribute.IsValid(prop.GetValue(result.Model))
select new { Propertie = prop.Name, ErrorMessage = attribute.FormatErrorMessage(string.Empty) };
foreach (var validationResultItem in validationResult)
bindingContext.ModelState.AddModelError(validationResultItem.Propertie, validationResultItem.ErrorMessage);
}
ModelState.IsValid returns always false (ValidationState is Unvalidated) so I try to clear it and validate it again explicitly. Now it's validating but only the properties of EditFormViewModel not properties of Products items.
validation asp.net-core model-binding
asked Nov 16 '18 at 9:27
a.farkas2508a.farkas2508
117210
add a comment |
I have an abstract class and few child classes and I'm using abstract model binder from this answer to bind them into specific class.
public abstract class BaseProductViewModel
{
public int Id { get; set; }
public string Type { get => GetType().FullName; }
public int DealerId { get; set; }
}
public class MortgageViewModel : BaseProductViewModel
{
// other properties with validation attributes
}
public class InsuranceViewModel : BaseProductViewModel
{
// other properties with validation attributes
}
My edit viewmodel has collection of these classes and some other properties.
public class EditFormViewModel
{
[Required]
public string FirstName { get; set; }
[Required]
public string LastName { get; set; }
// other properties with validation attributes
public IList<BaseProductViewModel> Products { get; set; }
}
Mapping works fine but validation of the Products list is a problem. I also added validation into BindModelAsync method:
using (bindingContext.EnterNestedScope(metadata, bindingContext.FieldName, bindingContext.ModelName, model: null))
{
await binder.BindModelAsync(bindingContext);
result = bindingContext.Result;
var validationResult = from prop in TypeDescriptor.GetProperties(result.Model).Cast<PropertyDescriptor>()
from attribute in prop.Attributes.OfType<ValidationAttribute>()
where !attribute.IsValid(prop.GetValue(result.Model))
select new { Propertie = prop.Name, ErrorMessage = attribute.FormatErrorMessage(string.Empty) };
foreach (var validationResultItem in validationResult)
bindingContext.ModelState.AddModelError(validationResultItem.Propertie, validationResultItem.ErrorMessage);
}
ModelState.IsValid returns always false (ValidationState is Unvalidated) so I try to clear it and validate it again explicitly. Now it's validating but only the properties of EditFormViewModel not properties of Products items.
validation asp.net-core model-binding
asked Nov 16 '18 at 9:27
a.farkas2508a.farkas2508
117210
add a comment |
I have an abstract class and few child classes and I'm using abstract model binder from this answer to bind them into specific class.
public abstract class BaseProductViewModel
{
public int Id { get; set; }
public string Type { get => GetType().FullName; }
public int DealerId { get; set; }
}
public class MortgageViewModel : BaseProductViewModel
{
// other properties with validation attributes
}
public class InsuranceViewModel : BaseProductViewModel
{
// other properties with validation attributes
}
My edit viewmodel has collection of these classes and some other properties.
public class EditFormViewModel
{
[Required]
public string FirstName { get; set; }
[Required]
public string LastName { get; set; }
// other properties with validation attributes
public IList<BaseProductViewModel> Products { get; set; }
}
Mapping works fine but validation of the Products list is a problem. I also added validation into BindModelAsync method:
using (bindingContext.EnterNestedScope(metadata, bindingContext.FieldName, bindingContext.ModelName, model: null))
{
await binder.BindModelAsync(bindingContext);
result = bindingContext.Result;
var validationResult = from prop in TypeDescriptor.GetProperties(result.Model).Cast<PropertyDescriptor>()
from attribute in prop.Attributes.OfType<ValidationAttribute>()
where !attribute.IsValid(prop.GetValue(result.Model))
select new { Propertie = prop.Name, ErrorMessage = attribute.FormatErrorMessage(string.Empty) };
foreach (var validationResultItem in validationResult)
bindingContext.ModelState.AddModelError(validationResultItem.Propertie, validationResultItem.ErrorMessage);
}
ModelState.IsValid returns always false (ValidationState is Unvalidated) so I try to clear it and validate it again explicitly. Now it's validating but only the properties of EditFormViewModel not properties of Products items.
validation asp.net-core model-binding
asked Nov 16 '18 at 9:27
a.farkas2508a.farkas2508
117210
I have an abstract class and few child classes and I'm using abstract model binder from this answer to bind them into specific class.
public abstract class BaseProductViewModel
{
public int Id { get; set; }
public string Type { get => GetType().FullName; }
public int DealerId { get; set; }
}
public class MortgageViewModel : BaseProductViewModel
{
// other properties with validation attributes
}
public class InsuranceViewModel : BaseProductViewModel
{
// other properties with validation attributes
}
My edit viewmodel has collection of these classes and some other properties.
public class EditFormViewModel
{
[Required]
public string FirstName { get; set; }
[Required]
public string LastName { get; set; }
// other properties with validation attributes
public IList<BaseProductViewModel> Products { get; set; }
}
Mapping works fine but validation of the Products list is a problem. I also added validation into BindModelAsync method:
using (bindingContext.EnterNestedScope(metadata, bindingContext.FieldName, bindingContext.ModelName, model: null))
{
await binder.BindModelAsync(bindingContext);
result = bindingContext.Result;
var validationResult = from prop in TypeDescriptor.GetProperties(result.Model).Cast<PropertyDescriptor>()
from attribute in prop.Attributes.OfType<ValidationAttribute>()
where !attribute.IsValid(prop.GetValue(result.Model))
select new { Propertie = prop.Name, ErrorMessage = attribute.FormatErrorMessage(string.Empty) };
foreach (var validationResultItem in validationResult)
bindingContext.ModelState.AddModelError(validationResultItem.Propertie, validationResultItem.ErrorMessage);
}
ModelState.IsValid returns always false (ValidationState is Unvalidated) so I try to clear it and validate it again explicitly. Now it's validating but only the properties of EditFormViewModel not properties of Products items.
validation asp.net-core model-binding
validation asp.net-core model-binding
asked Nov 16 '18 at 9:27
a.farkas2508a.farkas2508
117210
asked Nov 16 '18 at 9:27
a.farkas2508a.farkas2508
117210
asked Nov 16 '18 at 9:27
a.farkas2508a.farkas2508
117210
asked Nov 16 '18 at 9:27
a.farkas2508a.farkas2508
117210
asked Nov 16 '18 at 9:27
a.farkas2508a.farkas2508
117210
117210
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53334891%2fhow-to-validate-view-model-with-collection-of-abstract-items%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53334891%2fhow-to-validate-view-model-with-collection-of-abstract-items%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
