Reuse Fragment with flexible listeners












0














I have a Fragment which contains a Button. I want to reuse this Fragment, so the OnClickListener isn't hard coded but defined by the activity which calls this Fragment. The Activity implements the needed interface for this and the Fragment gets a reference in its oncreate method.



I have two questions on this below



public void TestFragment extends Fragment {

...
private IAction mAction = null;

@Override
public void OnAttach(Context ctx) {
mAction = (Action) getActivity();
}

@Override
public void onClickListener() {
action(this);
}

public interface IAction {
void action(Fragment f);
}

...
}


public class MainActivity extends AppCompatActivity implements IAction {
...

public void onCreate() {
getSupportFragmentManager().beginTransaction()
.add(R.id.content, Testfragment.gestInstance()
.commit();
}

public void IAction(Fragment f) {
f.doSomething()...
}

...
}



  1. Is this a good practice to build reusable fragments?


  2. I would to extend this: If this fragment is opened by an activity it uses the action defined in the activity. Ok, this works. It's the current behaviour.



But maybe this fragment is opened by another fragment (nested), so getActivity is wrong. Is there something like



if(parent.isActivity) {
mAction = (Action) getActivity()
} else if(parent.isFragment) {
mAction = (Action) getParentFragment()
}









share|improve this question



























    0














    I have a Fragment which contains a Button. I want to reuse this Fragment, so the OnClickListener isn't hard coded but defined by the activity which calls this Fragment. The Activity implements the needed interface for this and the Fragment gets a reference in its oncreate method.



    I have two questions on this below



    public void TestFragment extends Fragment {

    ...
    private IAction mAction = null;

    @Override
    public void OnAttach(Context ctx) {
    mAction = (Action) getActivity();
    }

    @Override
    public void onClickListener() {
    action(this);
    }

    public interface IAction {
    void action(Fragment f);
    }

    ...
    }


    public class MainActivity extends AppCompatActivity implements IAction {
    ...

    public void onCreate() {
    getSupportFragmentManager().beginTransaction()
    .add(R.id.content, Testfragment.gestInstance()
    .commit();
    }

    public void IAction(Fragment f) {
    f.doSomething()...
    }

    ...
    }



    1. Is this a good practice to build reusable fragments?


    2. I would to extend this: If this fragment is opened by an activity it uses the action defined in the activity. Ok, this works. It's the current behaviour.



    But maybe this fragment is opened by another fragment (nested), so getActivity is wrong. Is there something like



    if(parent.isActivity) {
    mAction = (Action) getActivity()
    } else if(parent.isFragment) {
    mAction = (Action) getParentFragment()
    }









    share|improve this question

























      0












      0








      0







      I have a Fragment which contains a Button. I want to reuse this Fragment, so the OnClickListener isn't hard coded but defined by the activity which calls this Fragment. The Activity implements the needed interface for this and the Fragment gets a reference in its oncreate method.



      I have two questions on this below



      public void TestFragment extends Fragment {

      ...
      private IAction mAction = null;

      @Override
      public void OnAttach(Context ctx) {
      mAction = (Action) getActivity();
      }

      @Override
      public void onClickListener() {
      action(this);
      }

      public interface IAction {
      void action(Fragment f);
      }

      ...
      }


      public class MainActivity extends AppCompatActivity implements IAction {
      ...

      public void onCreate() {
      getSupportFragmentManager().beginTransaction()
      .add(R.id.content, Testfragment.gestInstance()
      .commit();
      }

      public void IAction(Fragment f) {
      f.doSomething()...
      }

      ...
      }



      1. Is this a good practice to build reusable fragments?


      2. I would to extend this: If this fragment is opened by an activity it uses the action defined in the activity. Ok, this works. It's the current behaviour.



      But maybe this fragment is opened by another fragment (nested), so getActivity is wrong. Is there something like



      if(parent.isActivity) {
      mAction = (Action) getActivity()
      } else if(parent.isFragment) {
      mAction = (Action) getParentFragment()
      }









      share|improve this question













      I have a Fragment which contains a Button. I want to reuse this Fragment, so the OnClickListener isn't hard coded but defined by the activity which calls this Fragment. The Activity implements the needed interface for this and the Fragment gets a reference in its oncreate method.



      I have two questions on this below



      public void TestFragment extends Fragment {

      ...
      private IAction mAction = null;

      @Override
      public void OnAttach(Context ctx) {
      mAction = (Action) getActivity();
      }

      @Override
      public void onClickListener() {
      action(this);
      }

      public interface IAction {
      void action(Fragment f);
      }

      ...
      }


      public class MainActivity extends AppCompatActivity implements IAction {
      ...

      public void onCreate() {
      getSupportFragmentManager().beginTransaction()
      .add(R.id.content, Testfragment.gestInstance()
      .commit();
      }

      public void IAction(Fragment f) {
      f.doSomething()...
      }

      ...
      }



      1. Is this a good practice to build reusable fragments?


      2. I would to extend this: If this fragment is opened by an activity it uses the action defined in the activity. Ok, this works. It's the current behaviour.



      But maybe this fragment is opened by another fragment (nested), so getActivity is wrong. Is there something like



      if(parent.isActivity) {
      mAction = (Action) getActivity()
      } else if(parent.isFragment) {
      mAction = (Action) getParentFragment()
      }






      android android-fragments






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 13 '18 at 10:32









      HomerHomer

      312




      312
























          1 Answer
          1






          active

          oldest

          votes


















          0














          getActivity() will still work even if the fragment is nested within another one.



          But if you want to deligate it on the parent fragment, you can use getParentFragment()



          if (getParentFragment() != null) {
          // fragment is nested
          } else {
          // not nested
          }





          share|improve this answer























            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53279012%2freuse-fragment-with-flexible-listeners%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0














            getActivity() will still work even if the fragment is nested within another one.



            But if you want to deligate it on the parent fragment, you can use getParentFragment()



            if (getParentFragment() != null) {
            // fragment is nested
            } else {
            // not nested
            }





            share|improve this answer




























              0














              getActivity() will still work even if the fragment is nested within another one.



              But if you want to deligate it on the parent fragment, you can use getParentFragment()



              if (getParentFragment() != null) {
              // fragment is nested
              } else {
              // not nested
              }





              share|improve this answer


























                0












                0








                0






                getActivity() will still work even if the fragment is nested within another one.



                But if you want to deligate it on the parent fragment, you can use getParentFragment()



                if (getParentFragment() != null) {
                // fragment is nested
                } else {
                // not nested
                }





                share|improve this answer














                getActivity() will still work even if the fragment is nested within another one.



                But if you want to deligate it on the parent fragment, you can use getParentFragment()



                if (getParentFragment() != null) {
                // fragment is nested
                } else {
                // not nested
                }






                share|improve this answer














                share|improve this answer



                share|improve this answer








                edited Nov 13 '18 at 10:58

























                answered Nov 13 '18 at 10:44









                Samuel RobertSamuel Robert

                3,32052034




                3,32052034






























                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53279012%2freuse-fragment-with-flexible-listeners%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    List item for chat from Array inside array React Native

                    Thiostrepton

                    Caerphilly