Mockito verify and copy of array that gets cleared
I have a routine that does the following:
public void onEvent(List<Dto> pendingData)
{
eventDao.saveBatch(pendingData);
pendingData.clear();
}
In my test of the routine I use @Mock for eventDao:
@Mock
private EventDAO eventDao;
@Test
public void onEvent() {
// some preparations
handler.onEvent(testEvents);
// eventsExpectedToBePassed is the same as testEvents but it is an
// independent object populated separately
verify(eventDao, times(1)).saveBatch(eventsExpectedToBePassed);
}
verify fails with the information that the routine was called with empty array. This likely happens because Mockito simply stores reference to the array passed to the mock, and as you can see from the onEvent code, that array gets cleared in course of later execution. If I peform a copy by calling instead
eventDao.saveBatch(new ArrayList(pendingData));
then test passes OK. However, I like to avoid that since this is an extra operation that I do not need.
How I can either tell Mockito to save copy of passed array, not array itself, so when array is cleared, in the test code I have it retained for assertion?
java arrays junit mockito
asked Nov 13 '18 at 7:43
Askar IbragimovAskar Ibragimov
2,43064394
add a comment |
I have a routine that does the following:
public void onEvent(List<Dto> pendingData)
{
eventDao.saveBatch(pendingData);
pendingData.clear();
}
In my test of the routine I use @Mock for eventDao:
@Mock
private EventDAO eventDao;
@Test
public void onEvent() {
// some preparations
handler.onEvent(testEvents);
// eventsExpectedToBePassed is the same as testEvents but it is an
// independent object populated separately
verify(eventDao, times(1)).saveBatch(eventsExpectedToBePassed);
}
verify fails with the information that the routine was called with empty array. This likely happens because Mockito simply stores reference to the array passed to the mock, and as you can see from the onEvent code, that array gets cleared in course of later execution. If I peform a copy by calling instead
eventDao.saveBatch(new ArrayList(pendingData));
then test passes OK. However, I like to avoid that since this is an extra operation that I do not need.
How I can either tell Mockito to save copy of passed array, not array itself, so when array is cleared, in the test code I have it retained for assertion?
java arrays junit mockito
asked Nov 13 '18 at 7:43
Askar IbragimovAskar Ibragimov
2,43064394
Have you tried argument captor?
– mallaudin
Nov 13 '18 at 7:46
@mallaudin, no, appreciate an example.
– Askar Ibragimov
Nov 13 '18 at 7:46
Radical suggestion -mocktheList.
– Boris the Spider
Nov 13 '18 at 7:49
you can find an example here stackoverflow.com/questions/36253040/…
– mallaudin
Nov 13 '18 at 7:51
add a comment |
I have a routine that does the following:
public void onEvent(List<Dto> pendingData)
{
eventDao.saveBatch(pendingData);
pendingData.clear();
}
In my test of the routine I use @Mock for eventDao:
@Mock
private EventDAO eventDao;
@Test
public void onEvent() {
// some preparations
handler.onEvent(testEvents);
// eventsExpectedToBePassed is the same as testEvents but it is an
// independent object populated separately
verify(eventDao, times(1)).saveBatch(eventsExpectedToBePassed);
}
verify fails with the information that the routine was called with empty array. This likely happens because Mockito simply stores reference to the array passed to the mock, and as you can see from the onEvent code, that array gets cleared in course of later execution. If I peform a copy by calling instead
eventDao.saveBatch(new ArrayList(pendingData));
then test passes OK. However, I like to avoid that since this is an extra operation that I do not need.
How I can either tell Mockito to save copy of passed array, not array itself, so when array is cleared, in the test code I have it retained for assertion?
java arrays junit mockito
asked Nov 13 '18 at 7:43
Askar IbragimovAskar Ibragimov
2,43064394
I have a routine that does the following:
public void onEvent(List<Dto> pendingData)
{
eventDao.saveBatch(pendingData);
pendingData.clear();
}
In my test of the routine I use @Mock for eventDao:
@Mock
private EventDAO eventDao;
@Test
public void onEvent() {
// some preparations
handler.onEvent(testEvents);
// eventsExpectedToBePassed is the same as testEvents but it is an
// independent object populated separately
verify(eventDao, times(1)).saveBatch(eventsExpectedToBePassed);
}
verify fails with the information that the routine was called with empty array. This likely happens because Mockito simply stores reference to the array passed to the mock, and as you can see from the onEvent code, that array gets cleared in course of later execution. If I peform a copy by calling instead
eventDao.saveBatch(new ArrayList(pendingData));
then test passes OK. However, I like to avoid that since this is an extra operation that I do not need.
How I can either tell Mockito to save copy of passed array, not array itself, so when array is cleared, in the test code I have it retained for assertion?
java arrays junit mockito
java arrays junit mockito
asked Nov 13 '18 at 7:43
Askar IbragimovAskar Ibragimov
2,43064394
asked Nov 13 '18 at 7:43
Askar IbragimovAskar Ibragimov
2,43064394
asked Nov 13 '18 at 7:43
Askar IbragimovAskar Ibragimov
2,43064394
asked Nov 13 '18 at 7:43
Askar IbragimovAskar Ibragimov
2,43064394
asked Nov 13 '18 at 7:43
Askar IbragimovAskar Ibragimov
2,43064394
2,43064394
Have you tried argument captor?
– mallaudin
Nov 13 '18 at 7:46
@mallaudin, no, appreciate an example.
– Askar Ibragimov
Nov 13 '18 at 7:46
Radical suggestion -mocktheList.
– Boris the Spider
Nov 13 '18 at 7:49
you can find an example here stackoverflow.com/questions/36253040/…
– mallaudin
Nov 13 '18 at 7:51
add a comment |
Have you tried argument captor?
– mallaudin
Nov 13 '18 at 7:46
@mallaudin, no, appreciate an example.
– Askar Ibragimov
Nov 13 '18 at 7:46
Radical suggestion -mocktheList.
– Boris the Spider
Nov 13 '18 at 7:49
you can find an example here stackoverflow.com/questions/36253040/…
– mallaudin
Nov 13 '18 at 7:51
Have you tried argument captor?
– mallaudin
Nov 13 '18 at 7:46
Have you tried argument captor?
– mallaudin
Nov 13 '18 at 7:46
@mallaudin, no, appreciate an example.
– Askar Ibragimov
Nov 13 '18 at 7:46
@mallaudin, no, appreciate an example.
– Askar Ibragimov
Nov 13 '18 at 7:46
Radical suggestion -
mock the List.– Boris the Spider
Nov 13 '18 at 7:49
Radical suggestion -
mock the List.– Boris the Spider
Nov 13 '18 at 7:49
you can find an example here stackoverflow.com/questions/36253040/…
– mallaudin
Nov 13 '18 at 7:51
you can find an example here stackoverflow.com/questions/36253040/…
– mallaudin
Nov 13 '18 at 7:51
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53276094%2fmockito-verify-and-copy-of-array-that-gets-cleared%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53276094%2fmockito-verify-and-copy-of-array-that-gets-cleared%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Have you tried argument captor?
– mallaudin
Nov 13 '18 at 7:46
@mallaudin, no, appreciate an example.
– Askar Ibragimov
Nov 13 '18 at 7:46
Radical suggestion -
mocktheList.– Boris the Spider
Nov 13 '18 at 7:49
you can find an example here stackoverflow.com/questions/36253040/…
– mallaudin
Nov 13 '18 at 7:51