Can event.persist() cause memory leaks?
1
I have the following code:
onFieldChange(e) {
let selectionStart = e.target.selectionStart;
let selectionEnd = e.target.selectionEnd;
this.state.selectionStart = this.inputBox.current.selectionStart;
let value = this.formatNumber(e.target.value);
e.persist();
this.setState({value}, () => {
e.target.selectionStart = selectionStart
});
}
Can e.persist() cause a memory leak and if so how do I free it manually? And where does this method come from since I can't find documentation for it anywhere.
reactjs
asked Nov 12 at 15:41
faissaloo
217310
add a comment |
1
I have the following code:
onFieldChange(e) {
let selectionStart = e.target.selectionStart;
let selectionEnd = e.target.selectionEnd;
this.state.selectionStart = this.inputBox.current.selectionStart;
let value = this.formatNumber(e.target.value);
e.persist();
this.setState({value}, () => {
e.target.selectionStart = selectionStart
});
}
Can e.persist() cause a memory leak and if so how do I free it manually? And where does this method come from since I can't find documentation for it anywhere.
reactjs
asked Nov 12 at 15:41
faissaloo
217310
1
It just has a small note in theEvent Poolingsection of the documentation. What are you trying to achieve? You should not mutate state directly likethis.state.selectionStart. It's better to manipulate state with justsetState.
– Tholle
Nov 12 at 15:45
I'm trying to access e.target.selectionStart from thethis.setState()callback.
– faissaloo
Nov 12 at 15:57
Then you can take out the target from the event before thesetStatecall, and usetarget.selectionStartin the callback. This way the event doesn't have to be persisted.const { target } = event; this.setState({ value }, () => target.selectionStart = 'something');
– Tholle
Nov 12 at 16:00
add a comment |
1
1
1
I have the following code:
onFieldChange(e) {
let selectionStart = e.target.selectionStart;
let selectionEnd = e.target.selectionEnd;
this.state.selectionStart = this.inputBox.current.selectionStart;
let value = this.formatNumber(e.target.value);
e.persist();
this.setState({value}, () => {
e.target.selectionStart = selectionStart
});
}
Can e.persist() cause a memory leak and if so how do I free it manually? And where does this method come from since I can't find documentation for it anywhere.
reactjs
asked Nov 12 at 15:41
faissaloo
217310
I have the following code:
onFieldChange(e) {
let selectionStart = e.target.selectionStart;
let selectionEnd = e.target.selectionEnd;
this.state.selectionStart = this.inputBox.current.selectionStart;
let value = this.formatNumber(e.target.value);
e.persist();
this.setState({value}, () => {
e.target.selectionStart = selectionStart
});
}
Can e.persist() cause a memory leak and if so how do I free it manually? And where does this method come from since I can't find documentation for it anywhere.
reactjs
reactjs
asked Nov 12 at 15:41
faissaloo
217310
asked Nov 12 at 15:41
faissaloo
217310
asked Nov 12 at 15:41
faissaloo
217310
asked Nov 12 at 15:41
faissaloo
217310
asked Nov 12 at 15:41
faissaloo
217310
217310
1
It just has a small note in theEvent Poolingsection of the documentation. What are you trying to achieve? You should not mutate state directly likethis.state.selectionStart. It's better to manipulate state with justsetState.
– Tholle
Nov 12 at 15:45
I'm trying to access e.target.selectionStart from thethis.setState()callback.
– faissaloo
Nov 12 at 15:57
Then you can take out the target from the event before thesetStatecall, and usetarget.selectionStartin the callback. This way the event doesn't have to be persisted.const { target } = event; this.setState({ value }, () => target.selectionStart = 'something');
– Tholle
Nov 12 at 16:00
add a comment |
1
It just has a small note in theEvent Poolingsection of the documentation. What are you trying to achieve? You should not mutate state directly likethis.state.selectionStart. It's better to manipulate state with justsetState.
– Tholle
Nov 12 at 15:45
I'm trying to access e.target.selectionStart from thethis.setState()callback.
– faissaloo
Nov 12 at 15:57
Then you can take out the target from the event before thesetStatecall, and usetarget.selectionStartin the callback. This way the event doesn't have to be persisted.const { target } = event; this.setState({ value }, () => target.selectionStart = 'something');
– Tholle
Nov 12 at 16:00
1
1
It just has a small note in the
Event Pooling section of the documentation. What are you trying to achieve? You should not mutate state directly like this.state.selectionStart. It's better to manipulate state with just setState.– Tholle
Nov 12 at 15:45
It just has a small note in the
Event Pooling section of the documentation. What are you trying to achieve? You should not mutate state directly like this.state.selectionStart. It's better to manipulate state with just setState.– Tholle
Nov 12 at 15:45
I'm trying to access e.target.selectionStart from the
this.setState() callback.– faissaloo
Nov 12 at 15:57
I'm trying to access e.target.selectionStart from the
this.setState() callback.– faissaloo
Nov 12 at 15:57
Then you can take out the target from the event before the
setState call, and use target.selectionStart in the callback. This way the event doesn't have to be persisted. const { target } = event; this.setState({ value }, () => target.selectionStart = 'something');– Tholle
Nov 12 at 16:00
Then you can take out the target from the event before the
setState call, and use target.selectionStart in the callback. This way the event doesn't have to be persisted. const { target } = event; this.setState({ value }, () => target.selectionStart = 'something');– Tholle
Nov 12 at 16:00
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53265491%2fcan-event-persist-cause-memory-leaks%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53265491%2fcan-event-persist-cause-memory-leaks%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
It just has a small note in the
Event Poolingsection of the documentation. What are you trying to achieve? You should not mutate state directly likethis.state.selectionStart. It's better to manipulate state with justsetState.– Tholle
Nov 12 at 15:45
I'm trying to access e.target.selectionStart from the
this.setState()callback.– faissaloo
Nov 12 at 15:57
Then you can take out the target from the event before the
setStatecall, and usetarget.selectionStartin the callback. This way the event doesn't have to be persisted.const { target } = event; this.setState({ value }, () => target.selectionStart = 'something');– Tholle
Nov 12 at 16:00