Sinon: testing that a setter throws an exception not working
I am trying to test that an Angular component's setter will throw an error using Sinon. My component looks partially like this:
@Input( 'sceneMode' ) set sceneMode( newSceneMode: Cesium.SceneMode ) {
const scene = this.cesiumViewerService.getScene();
switch ( newSceneMode ) {
case Cesium.SceneMode.SCENE2D:
scene.morphTo2D( MORPH_DURATION );
break;
case Cesium.SceneMode.SCENE3D:
scene.morphTo3D( MORPH_DURATION );
break;
case Cesium.SceneMode.COLUMBUS_VIEW:
scene.morphToColumbusView( MORPH_DURATION );
break;
default:
throw new Error( `Cannot morph to SceneMode type ${newSceneMode}` );
}
}
My test looks like this:
it( 'should throw an error on invalid scene mode', () => {
sceneModeStub = sinon.stub( component, 'sceneMode' );
try {
sceneModeStub.sceneMode = 0;
} finally {
assert( sceneModeStub.threw() );
}
} );
I have tried moving the assert outside of the finally block. I have also tried using:
sceneModeStub = sinon.sandbox.stub( component, 'sceneMode' );
but Karma reports:
AssertionError: false == true
I know for certain that 0 is an invalid sceneMode and in fact if I remove the try/finally, the application throws the error in the component's setter.
How do I test this?
angular unit-testing jasmine karma-runner sinon asked Jan 8 '18 at 13:35
serlingpaserlingpa
2,702124080
add a comment |
I am trying to test that an Angular component's setter will throw an error using Sinon. My component looks partially like this:
@Input( 'sceneMode' ) set sceneMode( newSceneMode: Cesium.SceneMode ) {
const scene = this.cesiumViewerService.getScene();
switch ( newSceneMode ) {
case Cesium.SceneMode.SCENE2D:
scene.morphTo2D( MORPH_DURATION );
break;
case Cesium.SceneMode.SCENE3D:
scene.morphTo3D( MORPH_DURATION );
break;
case Cesium.SceneMode.COLUMBUS_VIEW:
scene.morphToColumbusView( MORPH_DURATION );
break;
default:
throw new Error( `Cannot morph to SceneMode type ${newSceneMode}` );
}
}
My test looks like this:
it( 'should throw an error on invalid scene mode', () => {
sceneModeStub = sinon.stub( component, 'sceneMode' );
try {
sceneModeStub.sceneMode = 0;
} finally {
assert( sceneModeStub.threw() );
}
} );
I have tried moving the assert outside of the finally block. I have also tried using:
sceneModeStub = sinon.sandbox.stub( component, 'sceneMode' );
but Karma reports:
AssertionError: false == true
I know for certain that 0 is an invalid sceneMode and in fact if I remove the try/finally, the application throws the error in the component's setter.
How do I test this?
angular unit-testing jasmine karma-runner sinon asked Jan 8 '18 at 13:35
serlingpaserlingpa
2,702124080
add a comment |
I am trying to test that an Angular component's setter will throw an error using Sinon. My component looks partially like this:
@Input( 'sceneMode' ) set sceneMode( newSceneMode: Cesium.SceneMode ) {
const scene = this.cesiumViewerService.getScene();
switch ( newSceneMode ) {
case Cesium.SceneMode.SCENE2D:
scene.morphTo2D( MORPH_DURATION );
break;
case Cesium.SceneMode.SCENE3D:
scene.morphTo3D( MORPH_DURATION );
break;
case Cesium.SceneMode.COLUMBUS_VIEW:
scene.morphToColumbusView( MORPH_DURATION );
break;
default:
throw new Error( `Cannot morph to SceneMode type ${newSceneMode}` );
}
}
My test looks like this:
it( 'should throw an error on invalid scene mode', () => {
sceneModeStub = sinon.stub( component, 'sceneMode' );
try {
sceneModeStub.sceneMode = 0;
} finally {
assert( sceneModeStub.threw() );
}
} );
I have tried moving the assert outside of the finally block. I have also tried using:
sceneModeStub = sinon.sandbox.stub( component, 'sceneMode' );
but Karma reports:
AssertionError: false == true
I know for certain that 0 is an invalid sceneMode and in fact if I remove the try/finally, the application throws the error in the component's setter.
How do I test this?
angular unit-testing jasmine karma-runner sinon asked Jan 8 '18 at 13:35
serlingpaserlingpa
2,702124080
I am trying to test that an Angular component's setter will throw an error using Sinon. My component looks partially like this:
@Input( 'sceneMode' ) set sceneMode( newSceneMode: Cesium.SceneMode ) {
const scene = this.cesiumViewerService.getScene();
switch ( newSceneMode ) {
case Cesium.SceneMode.SCENE2D:
scene.morphTo2D( MORPH_DURATION );
break;
case Cesium.SceneMode.SCENE3D:
scene.morphTo3D( MORPH_DURATION );
break;
case Cesium.SceneMode.COLUMBUS_VIEW:
scene.morphToColumbusView( MORPH_DURATION );
break;
default:
throw new Error( `Cannot morph to SceneMode type ${newSceneMode}` );
}
}
My test looks like this:
it( 'should throw an error on invalid scene mode', () => {
sceneModeStub = sinon.stub( component, 'sceneMode' );
try {
sceneModeStub.sceneMode = 0;
} finally {
assert( sceneModeStub.threw() );
}
} );
I have tried moving the assert outside of the finally block. I have also tried using:
sceneModeStub = sinon.sandbox.stub( component, 'sceneMode' );
but Karma reports:
AssertionError: false == true
I know for certain that 0 is an invalid sceneMode and in fact if I remove the try/finally, the application throws the error in the component's setter.
How do I test this?
angular unit-testing jasmine karma-runner sinon angular unit-testing jasmine karma-runner sinon asked Jan 8 '18 at 13:35
serlingpaserlingpa
2,702124080
asked Jan 8 '18 at 13:35
serlingpaserlingpa
2,702124080
edited Jan 8 '18 at 13:50
serlingpa
asked Jan 8 '18 at 13:35
serlingpaserlingpa
2,702124080
asked Jan 8 '18 at 13:35
serlingpaserlingpa
2,702124080
asked Jan 8 '18 at 13:35
serlingpaserlingpa
2,702124080
2,702124080
add a comment |
add a comment |
1 Answer
1
active
oldest
votes
Old question, but to answer in case it's still relevant.
It looks to me like you're stubbing the method that you want to test, which would be wrong. The method you want to test should always stay in original form, only dependencies should be stubbed.
When testing an exception one should pass in a function to sinon which it can call in order to cause the exception. This should work:
it( 'should throw an error on invalid scene mode', () => {
assert.threw( () => {
sceneModeStub.sceneMode = 0;
}, 'Cannot morph to SceneMode type 0')
} );
answered Nov 15 '18 at 12:19
Jens WegarJens Wegar
1,73331929
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f48151425%2fsinon-testing-that-a-setter-throws-an-exception-not-working%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
Old question, but to answer in case it's still relevant.
It looks to me like you're stubbing the method that you want to test, which would be wrong. The method you want to test should always stay in original form, only dependencies should be stubbed.
When testing an exception one should pass in a function to sinon which it can call in order to cause the exception. This should work:
it( 'should throw an error on invalid scene mode', () => {
assert.threw( () => {
sceneModeStub.sceneMode = 0;
}, 'Cannot morph to SceneMode type 0')
} );
answered Nov 15 '18 at 12:19
Jens WegarJens Wegar
1,73331929
add a comment |
Old question, but to answer in case it's still relevant.
It looks to me like you're stubbing the method that you want to test, which would be wrong. The method you want to test should always stay in original form, only dependencies should be stubbed.
When testing an exception one should pass in a function to sinon which it can call in order to cause the exception. This should work:
it( 'should throw an error on invalid scene mode', () => {
assert.threw( () => {
sceneModeStub.sceneMode = 0;
}, 'Cannot morph to SceneMode type 0')
} );
answered Nov 15 '18 at 12:19
Jens WegarJens Wegar
1,73331929
add a comment |
Old question, but to answer in case it's still relevant.
It looks to me like you're stubbing the method that you want to test, which would be wrong. The method you want to test should always stay in original form, only dependencies should be stubbed.
When testing an exception one should pass in a function to sinon which it can call in order to cause the exception. This should work:
it( 'should throw an error on invalid scene mode', () => {
assert.threw( () => {
sceneModeStub.sceneMode = 0;
}, 'Cannot morph to SceneMode type 0')
} );
answered Nov 15 '18 at 12:19
Jens WegarJens Wegar
1,73331929
Old question, but to answer in case it's still relevant.
It looks to me like you're stubbing the method that you want to test, which would be wrong. The method you want to test should always stay in original form, only dependencies should be stubbed.
When testing an exception one should pass in a function to sinon which it can call in order to cause the exception. This should work:
it( 'should throw an error on invalid scene mode', () => {
assert.threw( () => {
sceneModeStub.sceneMode = 0;
}, 'Cannot morph to SceneMode type 0')
} );
answered Nov 15 '18 at 12:19
Jens WegarJens Wegar
1,73331929
answered Nov 15 '18 at 12:19
Jens WegarJens Wegar
1,73331929
answered Nov 15 '18 at 12:19
Jens WegarJens Wegar
1,73331929
answered Nov 15 '18 at 12:19
Jens WegarJens Wegar
1,73331929
1,73331929
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f48151425%2fsinon-testing-that-a-setter-throws-an-exception-not-working%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
