SOLID Open/Closed - Interface Segregation Principles
0
I have applied the Open/Closed principle on the code I am currently working on. The example is given here:
def error_response(object)
return { errs: object.to_s, status_code: :internal_server_error,
has_error: true } if object.is_a?(Exception)
{ errs: object.errors.full_messages.as_json,
status_code: :internal_server_error, has_error: true }
end
The code is used in several places by several types of objects. The Interface Segregation principle states that the class should not have methods that are not called by all clients.
- How can I use these two principles together for the given example?
- Is Open/Closed principle dependant on Interface Segregation principle, or vice versa?
ruby-on-rails ruby solid-principles open-closed-principle
edited Nov 14 '18 at 14:48
Jørn Wildt
2,9411427
asked Nov 14 '18 at 11:47
Giorgi NikolaishviliGiorgi Nikolaishvili
1
add a comment |
0
I have applied the Open/Closed principle on the code I am currently working on. The example is given here:
def error_response(object)
return { errs: object.to_s, status_code: :internal_server_error,
has_error: true } if object.is_a?(Exception)
{ errs: object.errors.full_messages.as_json,
status_code: :internal_server_error, has_error: true }
end
The code is used in several places by several types of objects. The Interface Segregation principle states that the class should not have methods that are not called by all clients.
- How can I use these two principles together for the given example?
- Is Open/Closed principle dependant on Interface Segregation principle, or vice versa?
ruby-on-rails ruby solid-principles open-closed-principle
edited Nov 14 '18 at 14:48
Jørn Wildt
2,9411427
asked Nov 14 '18 at 11:47
Giorgi NikolaishviliGiorgi Nikolaishvili
1
Is this method not called by all clients?
– Sergio Tulentsev
Nov 14 '18 at 11:56
Yes, but parts of this method are not needed for every client. For example, Exception type objects use the first part while others use the second. Interface Segregation states that all clients should call the method the same way.
– Giorgi Nikolaishvili
Nov 14 '18 at 12:06
Maaaaaahbe this question is a better fit for programmers.se
– Sergio Tulentsev
Nov 14 '18 at 12:08
add a comment |
0
0
0
I have applied the Open/Closed principle on the code I am currently working on. The example is given here:
def error_response(object)
return { errs: object.to_s, status_code: :internal_server_error,
has_error: true } if object.is_a?(Exception)
{ errs: object.errors.full_messages.as_json,
status_code: :internal_server_error, has_error: true }
end
The code is used in several places by several types of objects. The Interface Segregation principle states that the class should not have methods that are not called by all clients.
- How can I use these two principles together for the given example?
- Is Open/Closed principle dependant on Interface Segregation principle, or vice versa?
ruby-on-rails ruby solid-principles open-closed-principle
edited Nov 14 '18 at 14:48
Jørn Wildt
2,9411427
asked Nov 14 '18 at 11:47
Giorgi NikolaishviliGiorgi Nikolaishvili
1
I have applied the Open/Closed principle on the code I am currently working on. The example is given here:
def error_response(object)
return { errs: object.to_s, status_code: :internal_server_error,
has_error: true } if object.is_a?(Exception)
{ errs: object.errors.full_messages.as_json,
status_code: :internal_server_error, has_error: true }
end
The code is used in several places by several types of objects. The Interface Segregation principle states that the class should not have methods that are not called by all clients.
- How can I use these two principles together for the given example?
- Is Open/Closed principle dependant on Interface Segregation principle, or vice versa?
ruby-on-rails ruby solid-principles open-closed-principle
ruby-on-rails ruby solid-principles open-closed-principle
edited Nov 14 '18 at 14:48
Jørn Wildt
2,9411427
asked Nov 14 '18 at 11:47
Giorgi NikolaishviliGiorgi Nikolaishvili
1
edited Nov 14 '18 at 14:48
Jørn Wildt
2,9411427
asked Nov 14 '18 at 11:47
Giorgi NikolaishviliGiorgi Nikolaishvili
1
edited Nov 14 '18 at 14:48
Jørn Wildt
2,9411427
edited Nov 14 '18 at 14:48
Jørn Wildt
2,9411427
edited Nov 14 '18 at 14:48
Jørn Wildt
2,9411427
2,9411427
asked Nov 14 '18 at 11:47
Giorgi NikolaishviliGiorgi Nikolaishvili
1
asked Nov 14 '18 at 11:47
Giorgi NikolaishviliGiorgi Nikolaishvili
1
asked Nov 14 '18 at 11:47
Giorgi NikolaishviliGiorgi Nikolaishvili
1
1
Is this method not called by all clients?
– Sergio Tulentsev
Nov 14 '18 at 11:56
Yes, but parts of this method are not needed for every client. For example, Exception type objects use the first part while others use the second. Interface Segregation states that all clients should call the method the same way.
– Giorgi Nikolaishvili
Nov 14 '18 at 12:06
Maaaaaahbe this question is a better fit for programmers.se
– Sergio Tulentsev
Nov 14 '18 at 12:08
add a comment |
Is this method not called by all clients?
– Sergio Tulentsev
Nov 14 '18 at 11:56
Yes, but parts of this method are not needed for every client. For example, Exception type objects use the first part while others use the second. Interface Segregation states that all clients should call the method the same way.
– Giorgi Nikolaishvili
Nov 14 '18 at 12:06
Maaaaaahbe this question is a better fit for programmers.se
– Sergio Tulentsev
Nov 14 '18 at 12:08
Is this method not called by all clients?
– Sergio Tulentsev
Nov 14 '18 at 11:56
Is this method not called by all clients?
– Sergio Tulentsev
Nov 14 '18 at 11:56
Yes, but parts of this method are not needed for every client. For example, Exception type objects use the first part while others use the second. Interface Segregation states that all clients should call the method the same way.
– Giorgi Nikolaishvili
Nov 14 '18 at 12:06
Yes, but parts of this method are not needed for every client. For example, Exception type objects use the first part while others use the second. Interface Segregation states that all clients should call the method the same way.
– Giorgi Nikolaishvili
Nov 14 '18 at 12:06
Maaaaaahbe this question is a better fit for programmers.se
– Sergio Tulentsev
Nov 14 '18 at 12:08
Maaaaaahbe this question is a better fit for programmers.se
– Sergio Tulentsev
Nov 14 '18 at 12:08
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53299533%2fsolid-open-closed-interface-segregation-principles%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53299533%2fsolid-open-closed-interface-segregation-principles%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Is this method not called by all clients?
– Sergio Tulentsev
Nov 14 '18 at 11:56
Yes, but parts of this method are not needed for every client. For example, Exception type objects use the first part while others use the second. Interface Segregation states that all clients should call the method the same way.
– Giorgi Nikolaishvili
Nov 14 '18 at 12:06
Maaaaaahbe this question is a better fit for programmers.se
– Sergio Tulentsev
Nov 14 '18 at 12:08