Angular 4-5: Custom directive not work in *ngFor
0
I have created a custom directive to allow only number value in a text box. Normally it's working fine but whenever I am trying to us inside the *ngFor it's not working at all.
Here OnlyNumber is custom directive.
import { Directive, ElementRef, ChangeDetectorRef, Input, HostListener } from "@angular/core";
import { NgControl } from "@angular/forms";
@Directive({
selector: '[OnlyNumber]'
})
export class OnlyNumberDirective {
constructor(private cdRef: ChangeDetectorRef, private el: ElementRef, private ngControl: NgControl) { }
@Input() OnlyNumber: boolean;
@HostListener('keydown', ['$event']) onKeyDown(event) {
let e = <KeyboardEvent> event;
if (this.OnlyNumber) {
if ([46, 8, 9, 27, 13, 110, 190].indexOf(e.keyCode) !== -1 ||
// Allow: Ctrl+A
(e.keyCode === 65 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+C
(e.keyCode === 67 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+V
(e.keyCode === 86 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+X
(e.keyCode === 88 && (e.ctrlKey || e.metaKey)) ||
// Allow: home, end, left, right
(e.keyCode >= 35 && e.keyCode <= 39)) {
// let it happen, don't do anything
return;
}
// Ensure that it is a number and stop the keypress
if ((e.shiftKey || (e.keyCode < 48 || e.keyCode > 57)) && (e.keyCode < 96 || e.keyCode > 105)) {
e.preventDefault();
}
}
}
}
Not Working Code
<tbody id="quote_type1_tbody" *ngFor="let loTempQuoteProduct of this.moTempQuoteProductList">
<tr>
<td>
<input type="text" id="ListCost" maxlength="8"
class="form-control m-input" placeholder="Enter list cost"
[ngModel]="TempProduct.Cost"
(ngModelChange)="TempProduct.Cost = $event;"
OnlyNumber="true">
</td>
</tr>
</tbody>
Working Code - Out side the ngFor
<input type="text" id="ListCost" maxlength="8"
class="form-control m-input" placeholder="Enter list cost"
[ngModel]="TempProduct.Cost"
(ngModelChange)="TempProduct.Cost = $event;"
OnlyNumber="true">
Your valuable time and answer will be appreciated.
Thanks in advice!!
angular angular-directive
asked Nov 14 '18 at 10:58
Nikunj B. BalarNikunj B. Balar
230315
|
show 8 more comments
0
I have created a custom directive to allow only number value in a text box. Normally it's working fine but whenever I am trying to us inside the *ngFor it's not working at all.
Here OnlyNumber is custom directive.
import { Directive, ElementRef, ChangeDetectorRef, Input, HostListener } from "@angular/core";
import { NgControl } from "@angular/forms";
@Directive({
selector: '[OnlyNumber]'
})
export class OnlyNumberDirective {
constructor(private cdRef: ChangeDetectorRef, private el: ElementRef, private ngControl: NgControl) { }
@Input() OnlyNumber: boolean;
@HostListener('keydown', ['$event']) onKeyDown(event) {
let e = <KeyboardEvent> event;
if (this.OnlyNumber) {
if ([46, 8, 9, 27, 13, 110, 190].indexOf(e.keyCode) !== -1 ||
// Allow: Ctrl+A
(e.keyCode === 65 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+C
(e.keyCode === 67 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+V
(e.keyCode === 86 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+X
(e.keyCode === 88 && (e.ctrlKey || e.metaKey)) ||
// Allow: home, end, left, right
(e.keyCode >= 35 && e.keyCode <= 39)) {
// let it happen, don't do anything
return;
}
// Ensure that it is a number and stop the keypress
if ((e.shiftKey || (e.keyCode < 48 || e.keyCode > 57)) && (e.keyCode < 96 || e.keyCode > 105)) {
e.preventDefault();
}
}
}
}
Not Working Code
<tbody id="quote_type1_tbody" *ngFor="let loTempQuoteProduct of this.moTempQuoteProductList">
<tr>
<td>
<input type="text" id="ListCost" maxlength="8"
class="form-control m-input" placeholder="Enter list cost"
[ngModel]="TempProduct.Cost"
(ngModelChange)="TempProduct.Cost = $event;"
OnlyNumber="true">
</td>
</tr>
</tbody>
Working Code - Out side the ngFor
<input type="text" id="ListCost" maxlength="8"
class="form-control m-input" placeholder="Enter list cost"
[ngModel]="TempProduct.Cost"
(ngModelChange)="TempProduct.Cost = $event;"
OnlyNumber="true">
Your valuable time and answer will be appreciated.
Thanks in advice!!
angular angular-directive
asked Nov 14 '18 at 10:58
Nikunj B. BalarNikunj B. Balar
230315
1
post your directive.
– Fateme Fazli
Nov 14 '18 at 11:00
Any error in console?
– Pardeep Jain
Nov 14 '18 at 11:03
What is the behavior, are you loosing the focus from the element ?
– Sunil Singh
Nov 14 '18 at 11:05
what do you mean by not working?
– Jota.Toledo
Nov 14 '18 at 11:07
@fatemefazli, I have edit question with directive code
– Nikunj B. Balar
Nov 14 '18 at 11:15
|
show 8 more comments
0
0
0
I have created a custom directive to allow only number value in a text box. Normally it's working fine but whenever I am trying to us inside the *ngFor it's not working at all.
Here OnlyNumber is custom directive.
import { Directive, ElementRef, ChangeDetectorRef, Input, HostListener } from "@angular/core";
import { NgControl } from "@angular/forms";
@Directive({
selector: '[OnlyNumber]'
})
export class OnlyNumberDirective {
constructor(private cdRef: ChangeDetectorRef, private el: ElementRef, private ngControl: NgControl) { }
@Input() OnlyNumber: boolean;
@HostListener('keydown', ['$event']) onKeyDown(event) {
let e = <KeyboardEvent> event;
if (this.OnlyNumber) {
if ([46, 8, 9, 27, 13, 110, 190].indexOf(e.keyCode) !== -1 ||
// Allow: Ctrl+A
(e.keyCode === 65 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+C
(e.keyCode === 67 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+V
(e.keyCode === 86 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+X
(e.keyCode === 88 && (e.ctrlKey || e.metaKey)) ||
// Allow: home, end, left, right
(e.keyCode >= 35 && e.keyCode <= 39)) {
// let it happen, don't do anything
return;
}
// Ensure that it is a number and stop the keypress
if ((e.shiftKey || (e.keyCode < 48 || e.keyCode > 57)) && (e.keyCode < 96 || e.keyCode > 105)) {
e.preventDefault();
}
}
}
}
Not Working Code
<tbody id="quote_type1_tbody" *ngFor="let loTempQuoteProduct of this.moTempQuoteProductList">
<tr>
<td>
<input type="text" id="ListCost" maxlength="8"
class="form-control m-input" placeholder="Enter list cost"
[ngModel]="TempProduct.Cost"
(ngModelChange)="TempProduct.Cost = $event;"
OnlyNumber="true">
</td>
</tr>
</tbody>
Working Code - Out side the ngFor
<input type="text" id="ListCost" maxlength="8"
class="form-control m-input" placeholder="Enter list cost"
[ngModel]="TempProduct.Cost"
(ngModelChange)="TempProduct.Cost = $event;"
OnlyNumber="true">
Your valuable time and answer will be appreciated.
Thanks in advice!!
angular angular-directive
asked Nov 14 '18 at 10:58
Nikunj B. BalarNikunj B. Balar
230315
I have created a custom directive to allow only number value in a text box. Normally it's working fine but whenever I am trying to us inside the *ngFor it's not working at all.
Here OnlyNumber is custom directive.
import { Directive, ElementRef, ChangeDetectorRef, Input, HostListener } from "@angular/core";
import { NgControl } from "@angular/forms";
@Directive({
selector: '[OnlyNumber]'
})
export class OnlyNumberDirective {
constructor(private cdRef: ChangeDetectorRef, private el: ElementRef, private ngControl: NgControl) { }
@Input() OnlyNumber: boolean;
@HostListener('keydown', ['$event']) onKeyDown(event) {
let e = <KeyboardEvent> event;
if (this.OnlyNumber) {
if ([46, 8, 9, 27, 13, 110, 190].indexOf(e.keyCode) !== -1 ||
// Allow: Ctrl+A
(e.keyCode === 65 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+C
(e.keyCode === 67 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+V
(e.keyCode === 86 && (e.ctrlKey || e.metaKey)) ||
// Allow: Ctrl+X
(e.keyCode === 88 && (e.ctrlKey || e.metaKey)) ||
// Allow: home, end, left, right
(e.keyCode >= 35 && e.keyCode <= 39)) {
// let it happen, don't do anything
return;
}
// Ensure that it is a number and stop the keypress
if ((e.shiftKey || (e.keyCode < 48 || e.keyCode > 57)) && (e.keyCode < 96 || e.keyCode > 105)) {
e.preventDefault();
}
}
}
}
Not Working Code
<tbody id="quote_type1_tbody" *ngFor="let loTempQuoteProduct of this.moTempQuoteProductList">
<tr>
<td>
<input type="text" id="ListCost" maxlength="8"
class="form-control m-input" placeholder="Enter list cost"
[ngModel]="TempProduct.Cost"
(ngModelChange)="TempProduct.Cost = $event;"
OnlyNumber="true">
</td>
</tr>
</tbody>
Working Code - Out side the ngFor
<input type="text" id="ListCost" maxlength="8"
class="form-control m-input" placeholder="Enter list cost"
[ngModel]="TempProduct.Cost"
(ngModelChange)="TempProduct.Cost = $event;"
OnlyNumber="true">
Your valuable time and answer will be appreciated.
Thanks in advice!!
angular angular-directive
angular angular-directive
asked Nov 14 '18 at 10:58
Nikunj B. BalarNikunj B. Balar
230315
asked Nov 14 '18 at 10:58
Nikunj B. BalarNikunj B. Balar
230315
edited Nov 14 '18 at 11:28
Nikunj B. Balar
asked Nov 14 '18 at 10:58
Nikunj B. BalarNikunj B. Balar
230315
asked Nov 14 '18 at 10:58
Nikunj B. BalarNikunj B. Balar
230315
asked Nov 14 '18 at 10:58
Nikunj B. BalarNikunj B. Balar
230315
230315
1
post your directive.
– Fateme Fazli
Nov 14 '18 at 11:00
Any error in console?
– Pardeep Jain
Nov 14 '18 at 11:03
What is the behavior, are you loosing the focus from the element ?
– Sunil Singh
Nov 14 '18 at 11:05
what do you mean by not working?
– Jota.Toledo
Nov 14 '18 at 11:07
@fatemefazli, I have edit question with directive code
– Nikunj B. Balar
Nov 14 '18 at 11:15
|
show 8 more comments
1
post your directive.
– Fateme Fazli
Nov 14 '18 at 11:00
Any error in console?
– Pardeep Jain
Nov 14 '18 at 11:03
What is the behavior, are you loosing the focus from the element ?
– Sunil Singh
Nov 14 '18 at 11:05
what do you mean by not working?
– Jota.Toledo
Nov 14 '18 at 11:07
@fatemefazli, I have edit question with directive code
– Nikunj B. Balar
Nov 14 '18 at 11:15
1
1
post your directive.
– Fateme Fazli
Nov 14 '18 at 11:00
post your directive.
– Fateme Fazli
Nov 14 '18 at 11:00
Any error in console?
– Pardeep Jain
Nov 14 '18 at 11:03
Any error in console?
– Pardeep Jain
Nov 14 '18 at 11:03
What is the behavior, are you loosing the focus from the element ?
– Sunil Singh
Nov 14 '18 at 11:05
What is the behavior, are you loosing the focus from the element ?
– Sunil Singh
Nov 14 '18 at 11:05
what do you mean by not working?
– Jota.Toledo
Nov 14 '18 at 11:07
what do you mean by not working?
– Jota.Toledo
Nov 14 '18 at 11:07
@fatemefazli, I have edit question with directive code
– Nikunj B. Balar
Nov 14 '18 at 11:15
@fatemefazli, I have edit question with directive code
– Nikunj B. Balar
Nov 14 '18 at 11:15
|
show 8 more comments
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53298609%2fangular-4-5-custom-directive-not-work-in-ngfor%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53298609%2fangular-4-5-custom-directive-not-work-in-ngfor%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
post your directive.
– Fateme Fazli
Nov 14 '18 at 11:00
Any error in console?
– Pardeep Jain
Nov 14 '18 at 11:03
What is the behavior, are you loosing the focus from the element ?
– Sunil Singh
Nov 14 '18 at 11:05
what do you mean by not working?
– Jota.Toledo
Nov 14 '18 at 11:07
@fatemefazli, I have edit question with directive code
– Nikunj B. Balar
Nov 14 '18 at 11:15