INotifyDataErrorInfo ErrorsChanged doesn't work for UI element bound to a ListCollectionView












0















This XAML element is bound to a ListCollectionView in my View Model:



<Style x:Key="ErrorStyle" TargetType="{x:Type Control}">
<Style.Triggers>
<Trigger Property="Validation.HasError" Value="true">
<Setter Property="ToolTip" Value="{Binding RelativeSource={x:Static RelativeSource.Self}, Path=(Validation.Errors)[0].ErrorContent}"/>
<Setter Property="Background" Value="Salmon"/>
</Trigger>
</Style.Triggers>
</Style>
...

<controls:AutoCompleteBox Grid.Column="1" Grid.Row="0" Margin="5" Height="20" Width="270" HorizontalAlignment="Left" VerticalAlignment="Center"
Name="typeName"
Style="{StaticResource ErrorStyle}"
Text="{Binding Path=AirframeCollectionView/TypeName, UpdateSourceTrigger=LostFocus, Mode=TwoWay,
ValidatesOnNotifyDataErrors=True,
NotifyOnValidationError=True,
ValidatesOnExceptions=True}"
ItemsSource="{Binding Path=TypeNames}"
IsTextCompletionEnabled="True"
FilterMode="Contains"
MinimumPrefixLength="3">
</controls:AutoCompleteBox>


The ListCollectionView is defined thus:



public ListCollectionView AirframeCollectionView
{
get
{
return this.airframeCollectionView;
}

set
{
this.airframeCollectionView = value;
this.RaisePropertyChanged("AirframeCollectionView");
}
}


and initialised:



this.currentAirframes = new ObservableCollection<Airframe>(this.UnitOfWork.Airframes.GetAirframesForRegistration(this.SearchRegistration));
this.AirframeCollectionView = (ListCollectionView)CollectionViewSource.GetDefaultView(this.currentAirframes);


When validating AirframeCollectionView/TypeName I'm using the INotifyDataErrorInfo interface hence:



private readonly Dictionary<string, ICollection<string>> validationErrors = new Dictionary<string, ICollection<string>>();

public event EventHandler<DataErrorsChangedEventArgs> ErrorsChanged;

public bool HasErrors
{
get { return this.validationErrors.Count > 0; }
}

public IEnumerable GetErrors(string propertyName)
{
if (string.IsNullOrEmpty(propertyName) || !this.validationErrors.ContainsKey(propertyName))
{
return null;
}

return this.validationErrors[propertyName];
}

private void RaiseErrorsChanged(string propertyName)
{
if (this.ErrorsChanged != null)
{
this.ErrorsChanged(this, new DataErrorsChangedEventArgs(propertyName));
}
}


To raise an error I've been doing this:



this.validationErrors["AirframeCollectionView/TypeName"] = validationErrors;
this.RaiseErrorsChanged("AirframeCollectionView/TypeName");


This doesn't trigger the error response in the UI however. I changed the property name from "AirframeCollectionView/TypeName" to "TypeName" but that doesn't work either. In the debugger I've confirmed that validationErrors gets loaded with errors and that ErrorsChanged is fired with the supplied property name.



Note that this was all working when I implemented INotifyDataErrorInfo in the Model rather than the ViewModel but for various reasons I want the implementation to be in ViewModel.



Question



What property name format do I have to use when setting up the DataErrorsChangedEventArgs and triggering ErrorsChanged? Or is there some other structural problem I have here?










share|improve this question



























    0















    This XAML element is bound to a ListCollectionView in my View Model:



    <Style x:Key="ErrorStyle" TargetType="{x:Type Control}">
    <Style.Triggers>
    <Trigger Property="Validation.HasError" Value="true">
    <Setter Property="ToolTip" Value="{Binding RelativeSource={x:Static RelativeSource.Self}, Path=(Validation.Errors)[0].ErrorContent}"/>
    <Setter Property="Background" Value="Salmon"/>
    </Trigger>
    </Style.Triggers>
    </Style>
    ...

    <controls:AutoCompleteBox Grid.Column="1" Grid.Row="0" Margin="5" Height="20" Width="270" HorizontalAlignment="Left" VerticalAlignment="Center"
    Name="typeName"
    Style="{StaticResource ErrorStyle}"
    Text="{Binding Path=AirframeCollectionView/TypeName, UpdateSourceTrigger=LostFocus, Mode=TwoWay,
    ValidatesOnNotifyDataErrors=True,
    NotifyOnValidationError=True,
    ValidatesOnExceptions=True}"
    ItemsSource="{Binding Path=TypeNames}"
    IsTextCompletionEnabled="True"
    FilterMode="Contains"
    MinimumPrefixLength="3">
    </controls:AutoCompleteBox>


    The ListCollectionView is defined thus:



    public ListCollectionView AirframeCollectionView
    {
    get
    {
    return this.airframeCollectionView;
    }

    set
    {
    this.airframeCollectionView = value;
    this.RaisePropertyChanged("AirframeCollectionView");
    }
    }


    and initialised:



    this.currentAirframes = new ObservableCollection<Airframe>(this.UnitOfWork.Airframes.GetAirframesForRegistration(this.SearchRegistration));
    this.AirframeCollectionView = (ListCollectionView)CollectionViewSource.GetDefaultView(this.currentAirframes);


    When validating AirframeCollectionView/TypeName I'm using the INotifyDataErrorInfo interface hence:



    private readonly Dictionary<string, ICollection<string>> validationErrors = new Dictionary<string, ICollection<string>>();

    public event EventHandler<DataErrorsChangedEventArgs> ErrorsChanged;

    public bool HasErrors
    {
    get { return this.validationErrors.Count > 0; }
    }

    public IEnumerable GetErrors(string propertyName)
    {
    if (string.IsNullOrEmpty(propertyName) || !this.validationErrors.ContainsKey(propertyName))
    {
    return null;
    }

    return this.validationErrors[propertyName];
    }

    private void RaiseErrorsChanged(string propertyName)
    {
    if (this.ErrorsChanged != null)
    {
    this.ErrorsChanged(this, new DataErrorsChangedEventArgs(propertyName));
    }
    }


    To raise an error I've been doing this:



    this.validationErrors["AirframeCollectionView/TypeName"] = validationErrors;
    this.RaiseErrorsChanged("AirframeCollectionView/TypeName");


    This doesn't trigger the error response in the UI however. I changed the property name from "AirframeCollectionView/TypeName" to "TypeName" but that doesn't work either. In the debugger I've confirmed that validationErrors gets loaded with errors and that ErrorsChanged is fired with the supplied property name.



    Note that this was all working when I implemented INotifyDataErrorInfo in the Model rather than the ViewModel but for various reasons I want the implementation to be in ViewModel.



    Question



    What property name format do I have to use when setting up the DataErrorsChangedEventArgs and triggering ErrorsChanged? Or is there some other structural problem I have here?










    share|improve this question

























      0












      0








      0








      This XAML element is bound to a ListCollectionView in my View Model:



      <Style x:Key="ErrorStyle" TargetType="{x:Type Control}">
      <Style.Triggers>
      <Trigger Property="Validation.HasError" Value="true">
      <Setter Property="ToolTip" Value="{Binding RelativeSource={x:Static RelativeSource.Self}, Path=(Validation.Errors)[0].ErrorContent}"/>
      <Setter Property="Background" Value="Salmon"/>
      </Trigger>
      </Style.Triggers>
      </Style>
      ...

      <controls:AutoCompleteBox Grid.Column="1" Grid.Row="0" Margin="5" Height="20" Width="270" HorizontalAlignment="Left" VerticalAlignment="Center"
      Name="typeName"
      Style="{StaticResource ErrorStyle}"
      Text="{Binding Path=AirframeCollectionView/TypeName, UpdateSourceTrigger=LostFocus, Mode=TwoWay,
      ValidatesOnNotifyDataErrors=True,
      NotifyOnValidationError=True,
      ValidatesOnExceptions=True}"
      ItemsSource="{Binding Path=TypeNames}"
      IsTextCompletionEnabled="True"
      FilterMode="Contains"
      MinimumPrefixLength="3">
      </controls:AutoCompleteBox>


      The ListCollectionView is defined thus:



      public ListCollectionView AirframeCollectionView
      {
      get
      {
      return this.airframeCollectionView;
      }

      set
      {
      this.airframeCollectionView = value;
      this.RaisePropertyChanged("AirframeCollectionView");
      }
      }


      and initialised:



      this.currentAirframes = new ObservableCollection<Airframe>(this.UnitOfWork.Airframes.GetAirframesForRegistration(this.SearchRegistration));
      this.AirframeCollectionView = (ListCollectionView)CollectionViewSource.GetDefaultView(this.currentAirframes);


      When validating AirframeCollectionView/TypeName I'm using the INotifyDataErrorInfo interface hence:



      private readonly Dictionary<string, ICollection<string>> validationErrors = new Dictionary<string, ICollection<string>>();

      public event EventHandler<DataErrorsChangedEventArgs> ErrorsChanged;

      public bool HasErrors
      {
      get { return this.validationErrors.Count > 0; }
      }

      public IEnumerable GetErrors(string propertyName)
      {
      if (string.IsNullOrEmpty(propertyName) || !this.validationErrors.ContainsKey(propertyName))
      {
      return null;
      }

      return this.validationErrors[propertyName];
      }

      private void RaiseErrorsChanged(string propertyName)
      {
      if (this.ErrorsChanged != null)
      {
      this.ErrorsChanged(this, new DataErrorsChangedEventArgs(propertyName));
      }
      }


      To raise an error I've been doing this:



      this.validationErrors["AirframeCollectionView/TypeName"] = validationErrors;
      this.RaiseErrorsChanged("AirframeCollectionView/TypeName");


      This doesn't trigger the error response in the UI however. I changed the property name from "AirframeCollectionView/TypeName" to "TypeName" but that doesn't work either. In the debugger I've confirmed that validationErrors gets loaded with errors and that ErrorsChanged is fired with the supplied property name.



      Note that this was all working when I implemented INotifyDataErrorInfo in the Model rather than the ViewModel but for various reasons I want the implementation to be in ViewModel.



      Question



      What property name format do I have to use when setting up the DataErrorsChangedEventArgs and triggering ErrorsChanged? Or is there some other structural problem I have here?










      share|improve this question














      This XAML element is bound to a ListCollectionView in my View Model:



      <Style x:Key="ErrorStyle" TargetType="{x:Type Control}">
      <Style.Triggers>
      <Trigger Property="Validation.HasError" Value="true">
      <Setter Property="ToolTip" Value="{Binding RelativeSource={x:Static RelativeSource.Self}, Path=(Validation.Errors)[0].ErrorContent}"/>
      <Setter Property="Background" Value="Salmon"/>
      </Trigger>
      </Style.Triggers>
      </Style>
      ...

      <controls:AutoCompleteBox Grid.Column="1" Grid.Row="0" Margin="5" Height="20" Width="270" HorizontalAlignment="Left" VerticalAlignment="Center"
      Name="typeName"
      Style="{StaticResource ErrorStyle}"
      Text="{Binding Path=AirframeCollectionView/TypeName, UpdateSourceTrigger=LostFocus, Mode=TwoWay,
      ValidatesOnNotifyDataErrors=True,
      NotifyOnValidationError=True,
      ValidatesOnExceptions=True}"
      ItemsSource="{Binding Path=TypeNames}"
      IsTextCompletionEnabled="True"
      FilterMode="Contains"
      MinimumPrefixLength="3">
      </controls:AutoCompleteBox>


      The ListCollectionView is defined thus:



      public ListCollectionView AirframeCollectionView
      {
      get
      {
      return this.airframeCollectionView;
      }

      set
      {
      this.airframeCollectionView = value;
      this.RaisePropertyChanged("AirframeCollectionView");
      }
      }


      and initialised:



      this.currentAirframes = new ObservableCollection<Airframe>(this.UnitOfWork.Airframes.GetAirframesForRegistration(this.SearchRegistration));
      this.AirframeCollectionView = (ListCollectionView)CollectionViewSource.GetDefaultView(this.currentAirframes);


      When validating AirframeCollectionView/TypeName I'm using the INotifyDataErrorInfo interface hence:



      private readonly Dictionary<string, ICollection<string>> validationErrors = new Dictionary<string, ICollection<string>>();

      public event EventHandler<DataErrorsChangedEventArgs> ErrorsChanged;

      public bool HasErrors
      {
      get { return this.validationErrors.Count > 0; }
      }

      public IEnumerable GetErrors(string propertyName)
      {
      if (string.IsNullOrEmpty(propertyName) || !this.validationErrors.ContainsKey(propertyName))
      {
      return null;
      }

      return this.validationErrors[propertyName];
      }

      private void RaiseErrorsChanged(string propertyName)
      {
      if (this.ErrorsChanged != null)
      {
      this.ErrorsChanged(this, new DataErrorsChangedEventArgs(propertyName));
      }
      }


      To raise an error I've been doing this:



      this.validationErrors["AirframeCollectionView/TypeName"] = validationErrors;
      this.RaiseErrorsChanged("AirframeCollectionView/TypeName");


      This doesn't trigger the error response in the UI however. I changed the property name from "AirframeCollectionView/TypeName" to "TypeName" but that doesn't work either. In the debugger I've confirmed that validationErrors gets loaded with errors and that ErrorsChanged is fired with the supplied property name.



      Note that this was all working when I implemented INotifyDataErrorInfo in the Model rather than the ViewModel but for various reasons I want the implementation to be in ViewModel.



      Question



      What property name format do I have to use when setting up the DataErrorsChangedEventArgs and triggering ErrorsChanged? Or is there some other structural problem I have here?







      c# wpf xaml listcollectionview inotifydataerrorinfo






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 15 '18 at 20:46









      ifinlayifinlay

      354417




      354417
























          1 Answer
          1






          active

          oldest

          votes


















          0














          I conclude that you can't get INotifyDataErrorInfo to talk to the UI when using a ListCollectionView property in your view model and firing ErrorsChanged from the view model. To get this working therefore I have:





          • In the model (POCO) - Implemented INotifyDataError. Included a public RaiseErrorsChanged method which allows a property name and error list to be passed in. This adds the errors to an error dictionary and then fires ErrorsChanged.


          • In the view model - Subscribed to the PropertyChanged event for each Airframe object in the ListCollectionView. In the PropertyChanged event handler I carry out validation and then call the airframe's RaiseErrorsChanged method with any error details.


          This keeps bespoke validation out of the model and all is well.






          share|improve this answer























            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














            draft saved

            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53327652%2finotifydataerrorinfo-errorschanged-doesnt-work-for-ui-element-bound-to-a-listco%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0














            I conclude that you can't get INotifyDataErrorInfo to talk to the UI when using a ListCollectionView property in your view model and firing ErrorsChanged from the view model. To get this working therefore I have:





            • In the model (POCO) - Implemented INotifyDataError. Included a public RaiseErrorsChanged method which allows a property name and error list to be passed in. This adds the errors to an error dictionary and then fires ErrorsChanged.


            • In the view model - Subscribed to the PropertyChanged event for each Airframe object in the ListCollectionView. In the PropertyChanged event handler I carry out validation and then call the airframe's RaiseErrorsChanged method with any error details.


            This keeps bespoke validation out of the model and all is well.






            share|improve this answer




























              0














              I conclude that you can't get INotifyDataErrorInfo to talk to the UI when using a ListCollectionView property in your view model and firing ErrorsChanged from the view model. To get this working therefore I have:





              • In the model (POCO) - Implemented INotifyDataError. Included a public RaiseErrorsChanged method which allows a property name and error list to be passed in. This adds the errors to an error dictionary and then fires ErrorsChanged.


              • In the view model - Subscribed to the PropertyChanged event for each Airframe object in the ListCollectionView. In the PropertyChanged event handler I carry out validation and then call the airframe's RaiseErrorsChanged method with any error details.


              This keeps bespoke validation out of the model and all is well.






              share|improve this answer


























                0












                0








                0







                I conclude that you can't get INotifyDataErrorInfo to talk to the UI when using a ListCollectionView property in your view model and firing ErrorsChanged from the view model. To get this working therefore I have:





                • In the model (POCO) - Implemented INotifyDataError. Included a public RaiseErrorsChanged method which allows a property name and error list to be passed in. This adds the errors to an error dictionary and then fires ErrorsChanged.


                • In the view model - Subscribed to the PropertyChanged event for each Airframe object in the ListCollectionView. In the PropertyChanged event handler I carry out validation and then call the airframe's RaiseErrorsChanged method with any error details.


                This keeps bespoke validation out of the model and all is well.






                share|improve this answer













                I conclude that you can't get INotifyDataErrorInfo to talk to the UI when using a ListCollectionView property in your view model and firing ErrorsChanged from the view model. To get this working therefore I have:





                • In the model (POCO) - Implemented INotifyDataError. Included a public RaiseErrorsChanged method which allows a property name and error list to be passed in. This adds the errors to an error dictionary and then fires ErrorsChanged.


                • In the view model - Subscribed to the PropertyChanged event for each Airframe object in the ListCollectionView. In the PropertyChanged event handler I carry out validation and then call the airframe's RaiseErrorsChanged method with any error details.


                This keeps bespoke validation out of the model and all is well.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 18 '18 at 15:53









                ifinlayifinlay

                354417




                354417
































                    draft saved

                    draft discarded




















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid



                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53327652%2finotifydataerrorinfo-errorschanged-doesnt-work-for-ui-element-bound-to-a-listco%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Xamarin.iOS Cant Deploy on Iphone

                    Glorious Revolution

                    Dulmage-Mendelsohn matrix decomposition in Python