Hibernate - multiples delete + insert operations without calling flush method causes duplicates
I have a relationship:
Parent {
@OneToMany(cascade = CascadeType.ALL, orphanRemoval = true, mappedBy = "parent")
private List<Child> children= new ArrayList<>();
}
Child {
@ManyToOne
private Parent parent;
}
I want to remove all children and add new ones. That's why I call:
List<Child> newChildren = Arrays.asList(firstChild, secondChild);
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent); - I'm using spring data
However I saw that when I call the above code twice (I have more complicated logic, but this is the simplest case how I was able to reproduce my problem) without calling flush() method, Hibernate adds duplicate entries to the database (parent will have 4 children):
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent);
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent);
Replacing savewith saveAndFlush fixes above code and causes that parent has only 2 children.
Why is it necessary to call flush method before deleting and inserting new children to the parent?
java hibernate spring-data-jpa
edited Nov 15 '18 at 8:15
buræquete
5,30442049
asked Nov 14 '18 at 13:18
TomaToma
242214
add a comment |
I have a relationship:
Parent {
@OneToMany(cascade = CascadeType.ALL, orphanRemoval = true, mappedBy = "parent")
private List<Child> children= new ArrayList<>();
}
Child {
@ManyToOne
private Parent parent;
}
I want to remove all children and add new ones. That's why I call:
List<Child> newChildren = Arrays.asList(firstChild, secondChild);
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent); - I'm using spring data
However I saw that when I call the above code twice (I have more complicated logic, but this is the simplest case how I was able to reproduce my problem) without calling flush() method, Hibernate adds duplicate entries to the database (parent will have 4 children):
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent);
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent);
Replacing savewith saveAndFlush fixes above code and causes that parent has only 2 children.
Why is it necessary to call flush method before deleting and inserting new children to the parent?
java hibernate spring-data-jpa
edited Nov 15 '18 at 8:15
buræquete
5,30442049
asked Nov 14 '18 at 13:18
TomaToma
242214
Maybe this can give you an hint: stackoverflow.com/questions/21203875/…
– Tu.ma
Nov 14 '18 at 13:27
add a comment |
I have a relationship:
Parent {
@OneToMany(cascade = CascadeType.ALL, orphanRemoval = true, mappedBy = "parent")
private List<Child> children= new ArrayList<>();
}
Child {
@ManyToOne
private Parent parent;
}
I want to remove all children and add new ones. That's why I call:
List<Child> newChildren = Arrays.asList(firstChild, secondChild);
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent); - I'm using spring data
However I saw that when I call the above code twice (I have more complicated logic, but this is the simplest case how I was able to reproduce my problem) without calling flush() method, Hibernate adds duplicate entries to the database (parent will have 4 children):
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent);
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent);
Replacing savewith saveAndFlush fixes above code and causes that parent has only 2 children.
Why is it necessary to call flush method before deleting and inserting new children to the parent?
java hibernate spring-data-jpa
edited Nov 15 '18 at 8:15
buræquete
5,30442049
asked Nov 14 '18 at 13:18
TomaToma
242214
I have a relationship:
Parent {
@OneToMany(cascade = CascadeType.ALL, orphanRemoval = true, mappedBy = "parent")
private List<Child> children= new ArrayList<>();
}
Child {
@ManyToOne
private Parent parent;
}
I want to remove all children and add new ones. That's why I call:
List<Child> newChildren = Arrays.asList(firstChild, secondChild);
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent); - I'm using spring data
However I saw that when I call the above code twice (I have more complicated logic, but this is the simplest case how I was able to reproduce my problem) without calling flush() method, Hibernate adds duplicate entries to the database (parent will have 4 children):
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent);
parent.getChildren().clear();
parent.getChildren().addAll(newChildren);
parentRepository.save(parent);
Replacing savewith saveAndFlush fixes above code and causes that parent has only 2 children.
Why is it necessary to call flush method before deleting and inserting new children to the parent?
java hibernate spring-data-jpa
java hibernate spring-data-jpa
edited Nov 15 '18 at 8:15
buræquete
5,30442049
asked Nov 14 '18 at 13:18
TomaToma
242214
edited Nov 15 '18 at 8:15
buræquete
5,30442049
asked Nov 14 '18 at 13:18
TomaToma
242214
edited Nov 15 '18 at 8:15
buræquete
5,30442049
edited Nov 15 '18 at 8:15
buræquete
5,30442049
edited Nov 15 '18 at 8:15
buræquete
5,30442049
5,30442049
asked Nov 14 '18 at 13:18
TomaToma
242214
asked Nov 14 '18 at 13:18
TomaToma
242214
asked Nov 14 '18 at 13:18
TomaToma
242214
242214
Maybe this can give you an hint: stackoverflow.com/questions/21203875/…
– Tu.ma
Nov 14 '18 at 13:27
add a comment |
Maybe this can give you an hint: stackoverflow.com/questions/21203875/…
– Tu.ma
Nov 14 '18 at 13:27
Maybe this can give you an hint: stackoverflow.com/questions/21203875/…
– Tu.ma
Nov 14 '18 at 13:27
Maybe this can give you an hint: stackoverflow.com/questions/21203875/…
– Tu.ma
Nov 14 '18 at 13:27
add a comment |
1 Answer
1
active
oldest
votes
From CrudRepository#save javadoc:
S save(S entity)
Saves a given entity. Use the returned instance for further operations as the save operation might have changed the entity instance completely.
So I believe your problem will be solved when you replace by:
parent = parentRepository.save(parent);
In your code, you continue operation on entity not attached to context, thus causing duplications.
answered Nov 14 '18 at 13:46
Alex SalauyouAlex Salauyou
11.1k43360
Nope, it doesn't fix this issue.
– Toma
Nov 14 '18 at 15:29
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53301174%2fhibernate-multiples-delete-insert-operations-without-calling-flush-method-ca%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
1 Answer
1
active
oldest
votes
1 Answer
1
active
oldest
votes
active
oldest
votes
active
oldest
votes
From CrudRepository#save javadoc:
S save(S entity)
Saves a given entity. Use the returned instance for further operations as the save operation might have changed the entity instance completely.
So I believe your problem will be solved when you replace by:
parent = parentRepository.save(parent);
In your code, you continue operation on entity not attached to context, thus causing duplications.
answered Nov 14 '18 at 13:46
Alex SalauyouAlex Salauyou
11.1k43360
Nope, it doesn't fix this issue.
– Toma
Nov 14 '18 at 15:29
add a comment |
From CrudRepository#save javadoc:
S save(S entity)
Saves a given entity. Use the returned instance for further operations as the save operation might have changed the entity instance completely.
So I believe your problem will be solved when you replace by:
parent = parentRepository.save(parent);
In your code, you continue operation on entity not attached to context, thus causing duplications.
answered Nov 14 '18 at 13:46
Alex SalauyouAlex Salauyou
11.1k43360
Nope, it doesn't fix this issue.
– Toma
Nov 14 '18 at 15:29
add a comment |
From CrudRepository#save javadoc:
S save(S entity)
Saves a given entity. Use the returned instance for further operations as the save operation might have changed the entity instance completely.
So I believe your problem will be solved when you replace by:
parent = parentRepository.save(parent);
In your code, you continue operation on entity not attached to context, thus causing duplications.
answered Nov 14 '18 at 13:46
Alex SalauyouAlex Salauyou
11.1k43360
From CrudRepository#save javadoc:
S save(S entity)
Saves a given entity. Use the returned instance for further operations as the save operation might have changed the entity instance completely.
So I believe your problem will be solved when you replace by:
parent = parentRepository.save(parent);
In your code, you continue operation on entity not attached to context, thus causing duplications.
answered Nov 14 '18 at 13:46
Alex SalauyouAlex Salauyou
11.1k43360
edited Nov 14 '18 at 13:51
answered Nov 14 '18 at 13:46
Alex SalauyouAlex Salauyou
11.1k43360
answered Nov 14 '18 at 13:46
Alex SalauyouAlex Salauyou
11.1k43360
answered Nov 14 '18 at 13:46
Alex SalauyouAlex Salauyou
11.1k43360
11.1k43360
Nope, it doesn't fix this issue.
– Toma
Nov 14 '18 at 15:29
add a comment |
Nope, it doesn't fix this issue.
– Toma
Nov 14 '18 at 15:29
Nope, it doesn't fix this issue.
– Toma
Nov 14 '18 at 15:29
Nope, it doesn't fix this issue.
– Toma
Nov 14 '18 at 15:29
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53301174%2fhibernate-multiples-delete-insert-operations-without-calling-flush-method-ca%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Maybe this can give you an hint: stackoverflow.com/questions/21203875/…
– Tu.ma
Nov 14 '18 at 13:27