Why don't we write axios.get(blabla) inside the render method?











up vote
0
down vote

favorite
1












Why don't we write



axios
.get('https://rallycoding.herokuapp.com/api/music_albums')
.then(response => this.setState({ albums: response.data }));


inside the render method, do we have to put it in componentWillMount?



What would be wrong if we put it at the beginning of the render method?



I put it in the render and got the same result but the tutorial says that it should be in componentWillMount.










share|improve this question
























  • Well, you'd be submitting a request every time you rerendered, plus you should NEVER set state in render, or in a callback of an async function in render.
    – Li357
    Jul 11 '17 at 5:04















up vote
0
down vote

favorite
1












Why don't we write



axios
.get('https://rallycoding.herokuapp.com/api/music_albums')
.then(response => this.setState({ albums: response.data }));


inside the render method, do we have to put it in componentWillMount?



What would be wrong if we put it at the beginning of the render method?



I put it in the render and got the same result but the tutorial says that it should be in componentWillMount.










share|improve this question
























  • Well, you'd be submitting a request every time you rerendered, plus you should NEVER set state in render, or in a callback of an async function in render.
    – Li357
    Jul 11 '17 at 5:04













up vote
0
down vote

favorite
1









up vote
0
down vote

favorite
1






1





Why don't we write



axios
.get('https://rallycoding.herokuapp.com/api/music_albums')
.then(response => this.setState({ albums: response.data }));


inside the render method, do we have to put it in componentWillMount?



What would be wrong if we put it at the beginning of the render method?



I put it in the render and got the same result but the tutorial says that it should be in componentWillMount.










share|improve this question















Why don't we write



axios
.get('https://rallycoding.herokuapp.com/api/music_albums')
.then(response => this.setState({ albums: response.data }));


inside the render method, do we have to put it in componentWillMount?



What would be wrong if we put it at the beginning of the render method?



I put it in the render and got the same result but the tutorial says that it should be in componentWillMount.







javascript reactjs react-native






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited Nov 11 at 12:06









Cœur

17.1k9102140




17.1k9102140










asked Jul 11 '17 at 5:01









farmcommand2

243414




243414












  • Well, you'd be submitting a request every time you rerendered, plus you should NEVER set state in render, or in a callback of an async function in render.
    – Li357
    Jul 11 '17 at 5:04


















  • Well, you'd be submitting a request every time you rerendered, plus you should NEVER set state in render, or in a callback of an async function in render.
    – Li357
    Jul 11 '17 at 5:04
















Well, you'd be submitting a request every time you rerendered, plus you should NEVER set state in render, or in a callback of an async function in render.
– Li357
Jul 11 '17 at 5:04




Well, you'd be submitting a request every time you rerendered, plus you should NEVER set state in render, or in a callback of an async function in render.
– Li357
Jul 11 '17 at 5:04












1 Answer
1






active

oldest

votes

















up vote
3
down vote



accepted










In general, the difference between the two would be in how many times do you want to make this request.



If you want the request to happen only the first time the component is mounted, you will use ComponentWillMount (preferable)



If you want the request to happen on every render (discouraged), then use the render method.



In your case, putting it in the render method would actually cause an infinite recursion because each request calls setState which will cause a re-render which will make the request which will call setState which will cause a re-render...



Not to mention the cost on performance as well as the network congestion from so many frequent requests.






class Example extends React.Component {
constructor() {
super()
this.state = {
counter: 0
}
}
render() {
// fake async action to act as a request
setTimeout(() => {
const { counter } = this.state;
this.setState({
counter: counter + 1
})
}, 500)
return React.createElement('h3', null, this.state.counter)
}
}

ReactDOM.render(
React.createElement(Example),
document.querySelector('#example')
)

<script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.js"></script>
<h2>Re-rendering forever</h2>
<div id="example"></div>








share|improve this answer























    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f45025775%2fwhy-dont-we-write-axios-getblabla-inside-the-render-method%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes








    up vote
    3
    down vote



    accepted










    In general, the difference between the two would be in how many times do you want to make this request.



    If you want the request to happen only the first time the component is mounted, you will use ComponentWillMount (preferable)



    If you want the request to happen on every render (discouraged), then use the render method.



    In your case, putting it in the render method would actually cause an infinite recursion because each request calls setState which will cause a re-render which will make the request which will call setState which will cause a re-render...



    Not to mention the cost on performance as well as the network congestion from so many frequent requests.






    class Example extends React.Component {
    constructor() {
    super()
    this.state = {
    counter: 0
    }
    }
    render() {
    // fake async action to act as a request
    setTimeout(() => {
    const { counter } = this.state;
    this.setState({
    counter: counter + 1
    })
    }, 500)
    return React.createElement('h3', null, this.state.counter)
    }
    }

    ReactDOM.render(
    React.createElement(Example),
    document.querySelector('#example')
    )

    <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.js"></script>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.js"></script>
    <h2>Re-rendering forever</h2>
    <div id="example"></div>








    share|improve this answer



























      up vote
      3
      down vote



      accepted










      In general, the difference between the two would be in how many times do you want to make this request.



      If you want the request to happen only the first time the component is mounted, you will use ComponentWillMount (preferable)



      If you want the request to happen on every render (discouraged), then use the render method.



      In your case, putting it in the render method would actually cause an infinite recursion because each request calls setState which will cause a re-render which will make the request which will call setState which will cause a re-render...



      Not to mention the cost on performance as well as the network congestion from so many frequent requests.






      class Example extends React.Component {
      constructor() {
      super()
      this.state = {
      counter: 0
      }
      }
      render() {
      // fake async action to act as a request
      setTimeout(() => {
      const { counter } = this.state;
      this.setState({
      counter: counter + 1
      })
      }, 500)
      return React.createElement('h3', null, this.state.counter)
      }
      }

      ReactDOM.render(
      React.createElement(Example),
      document.querySelector('#example')
      )

      <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.js"></script>
      <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.js"></script>
      <h2>Re-rendering forever</h2>
      <div id="example"></div>








      share|improve this answer

























        up vote
        3
        down vote



        accepted







        up vote
        3
        down vote



        accepted






        In general, the difference between the two would be in how many times do you want to make this request.



        If you want the request to happen only the first time the component is mounted, you will use ComponentWillMount (preferable)



        If you want the request to happen on every render (discouraged), then use the render method.



        In your case, putting it in the render method would actually cause an infinite recursion because each request calls setState which will cause a re-render which will make the request which will call setState which will cause a re-render...



        Not to mention the cost on performance as well as the network congestion from so many frequent requests.






        class Example extends React.Component {
        constructor() {
        super()
        this.state = {
        counter: 0
        }
        }
        render() {
        // fake async action to act as a request
        setTimeout(() => {
        const { counter } = this.state;
        this.setState({
        counter: counter + 1
        })
        }, 500)
        return React.createElement('h3', null, this.state.counter)
        }
        }

        ReactDOM.render(
        React.createElement(Example),
        document.querySelector('#example')
        )

        <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.js"></script>
        <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.js"></script>
        <h2>Re-rendering forever</h2>
        <div id="example"></div>








        share|improve this answer














        In general, the difference between the two would be in how many times do you want to make this request.



        If you want the request to happen only the first time the component is mounted, you will use ComponentWillMount (preferable)



        If you want the request to happen on every render (discouraged), then use the render method.



        In your case, putting it in the render method would actually cause an infinite recursion because each request calls setState which will cause a re-render which will make the request which will call setState which will cause a re-render...



        Not to mention the cost on performance as well as the network congestion from so many frequent requests.






        class Example extends React.Component {
        constructor() {
        super()
        this.state = {
        counter: 0
        }
        }
        render() {
        // fake async action to act as a request
        setTimeout(() => {
        const { counter } = this.state;
        this.setState({
        counter: counter + 1
        })
        }, 500)
        return React.createElement('h3', null, this.state.counter)
        }
        }

        ReactDOM.render(
        React.createElement(Example),
        document.querySelector('#example')
        )

        <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.js"></script>
        <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.js"></script>
        <h2>Re-rendering forever</h2>
        <div id="example"></div>








        class Example extends React.Component {
        constructor() {
        super()
        this.state = {
        counter: 0
        }
        }
        render() {
        // fake async action to act as a request
        setTimeout(() => {
        const { counter } = this.state;
        this.setState({
        counter: counter + 1
        })
        }, 500)
        return React.createElement('h3', null, this.state.counter)
        }
        }

        ReactDOM.render(
        React.createElement(Example),
        document.querySelector('#example')
        )

        <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.js"></script>
        <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.js"></script>
        <h2>Re-rendering forever</h2>
        <div id="example"></div>





        class Example extends React.Component {
        constructor() {
        super()
        this.state = {
        counter: 0
        }
        }
        render() {
        // fake async action to act as a request
        setTimeout(() => {
        const { counter } = this.state;
        this.setState({
        counter: counter + 1
        })
        }, 500)
        return React.createElement('h3', null, this.state.counter)
        }
        }

        ReactDOM.render(
        React.createElement(Example),
        document.querySelector('#example')
        )

        <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.js"></script>
        <script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.js"></script>
        <h2>Re-rendering forever</h2>
        <div id="example"></div>






        share|improve this answer














        share|improve this answer



        share|improve this answer








        edited Jul 11 '17 at 5:16

























        answered Jul 11 '17 at 5:05









        nem035

        23.5k43760




        23.5k43760






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.





            Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


            Please pay close attention to the following guidance:


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f45025775%2fwhy-dont-we-write-axios-getblabla-inside-the-render-method%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Bressuire

            Vorschmack

            Quarantine