Vfrdtyky

Update and fixed: I have fixed the problem causing the error message- Huge thanks to user PaulMcKenzie for helping me understand what the error message was telling me!- When my program encountered a letter with a mark above it (diacritical marks I think they are called), it crashed. I have adjusted my code to account for these and now it doesn't crash at all! Another huge thanks to user ihavenoidea for helping me understand multisets! My program is now working the way it's supposed to!

Original post:
****I am VERY new to C++ so any and all help is appreciated!****

Ok, so I'm trying to use multiset to sort words so I can see how many times a word appears in a text. First, my program accepts a file, then it reads the words and takes out any punctuation, then it puts it into a multiset. After this, it is supposed to put the results into a text file the user names themselves.

My first issue is that the multiset seems to be creating more than one element for the same word (For example: in one of my tests I saw a(4) listed in the text document 3 times in a row instead of one time).

My Second issue is that when I try to read in large text documents (I'm using John Colliers story "Bottle Party" http://ciscohouston.com/docs/docs/greats/bottle_party.html to test it) my program completely crashes but doesn't crash when I test it with a smaller text document (small being with say about 5-10 lines of text). I'm using Visual Studios and (once again I'm new to Visual Studios also) I don't know what the error message is trying to tell me but it says:

After selecting retry:

As always, any and all help is greatly appreciated.

Code here:

#include <iostream>

#include <string> //for strings

#include <fstream> //for files

#include <set> //for use of multiset



using namespace std;



string cleanUpPunc(string);



//Global variables

multiset <string> words; //will change back to local variable later



int main() {

//Starting variables

string fileName1 = "", fileName2 = "", input = "", input2 = ""; //To hold the input file and the file we wish to print data to if desired

ifstream fileStream; //gets infor from file



//Program start

cout << "Welcome to Bags Program by Rachel Woods!" << endl;

cout << "Please enter the name of the file you wish to input data from: ";

getline(cin, fileName1);



//Trys to open file

try {

    fileStream.open(fileName1);

    if (!fileStream) {

        cerr << "Unable to open file, please check file name and try again." << endl;

        system("PAUSE");

        exit(1);

    }



    while (fileStream >> input) {

        input2 = cleanUpPunc(input); //sends the input word to check for punctation

        words.insert(input2); //puts the 'cleaned up' word into the multiset for counting

    }

    fileStream.close();



        //Sends it to a text document

        cout << "Please name the file you would like to put the results into: ";

        getline(cin, fileName2);



        ofstream toFile; //writes info to a file



                         //Code to put info into text file

        toFile.open(fileName2);

        if (toFile.is_open()) {



            multiset<string>::iterator pos;

            for (pos = words.begin(); pos != words.end(); pos++) {

                toFile << *pos << " " << words.count(*pos) << endl;

            }

            toFile.close();

            cout << "Results written to file!" << endl;



        }

        else {

            cout << "Could not create file, please try again." << endl;

        }



    }catch (exception e) {

    cout << "Stop that. ";

    cout << e.what();

}



cout << "Thanks for using this program!" << endl;

system("PAUSE");

return 0;

}



string cleanUpPunc(string maybe) {

//Takes out puncuation from string

//Variables

string takeOut = maybe;



//Method



for (int i = 0, len = maybe.size(); i < len; i++) {

    if (ispunct(takeOut[i])) {

        takeOut.erase(i--, 1);

        len = takeOut.size();

    }

}



return takeOut;

}