Enzyme: with shallow, redux store update does not trigger componentDidUpdate
I'm having trouble testing a very specific use case of my React components. In this case, I have a component that dispatches an action on mount, and then dispatches another action after the results of the first dispatch come in.
The problem, I believe, comes down to enzyme's shallow
method not calling componentDidUpdate
in my component. I have reproduced the problem with the simplest code I could, and confirmed that the problem disappears if I use mount
instead of shallow
. However, enzyme's documentation says that since version 3, shallow
does call React's lifecycle methods such as componentDidUpdate
. And of course, I cannot use mount
in my test because I don't want to mount the entire tree (in my case, that would mean loading my entire application).
Thus I wonder: is this a bug in enzyme, or I am missing something in my usage of that library?
Here's my code example:
import * as React from 'react';
import { connect } from 'react-redux';
import { createStore } from 'redux';
import { shallow } from 'enzyme';
import sinon from 'sinon';
const actions = {
// This would fetch a resource on the network.
getList: () => {},
receiveList: list => {
return {
type: 'RECEIVE_LIST',
list,
};
},
// This would fetch a list of resources on the network.
getObjects: () => {},
};
const reducer = (state = { list: }, action) => {
switch (action.type) {
case 'RECEIVE_LIST':
return { ...state, list: action.list };
default:
return state;
}
};
class MyAppBase extends React.Component {
componentDidMount() {
this.props.dispatch(actions.getList());
}
componentDidUpdate(nextProps) {
if (nextProps.list !== this.props.list) {
this.props.dispatch(actions.getObjects(nextProps.list));
}
}
render() {
return null;
}
}
const MyApp = connect(state => { return { list: state.list }; })(MyAppBase);
describe('<MyApp>', () => {
it('fetches objects once list is received', () => {
// Mock actions that call the network.
sinon.stub(actions, 'getList');
actions.getList.returns({type: 'whatever'});
sinon.stub(actions, 'getObjects');
actions.getObjects.returns({type: 'whatever'});
// Create a redux store.
const store = createStore(reducer);
// Create the component.
const wrapper = shallow(<MyApp store={store} />);
// Verify that `componentDidMount` was called but not `componentDidUpdate`.
expect(actions.getList.callCount).toEqual(1);
expect(actions.getObjects.callCount).toEqual(0);
// Dispatch an action that will change the redux store.
store.dispatch(actions.receiveList([ 'aa', 'bb' ]));
// Expect the `componentDidUpdate` method to be called.
expect(actions.getObjects.callCount).toEqual(1);
// This doesn't work, for some reason `componentDidUpdate` is never called.
});
});
Package versions I use for this:
"react": "16.6.0",
"react-dom": "16.6.0",
"react-redux": "5.1.0",
"redux": "4.0.1",
"enzyme": "3.7.0",
"enzyme-adapter-react-16": "1.6.0",
"sinon": "7.1.0"
Thanks!
reactjs redux react-redux enzyme
add a comment |
I'm having trouble testing a very specific use case of my React components. In this case, I have a component that dispatches an action on mount, and then dispatches another action after the results of the first dispatch come in.
The problem, I believe, comes down to enzyme's shallow
method not calling componentDidUpdate
in my component. I have reproduced the problem with the simplest code I could, and confirmed that the problem disappears if I use mount
instead of shallow
. However, enzyme's documentation says that since version 3, shallow
does call React's lifecycle methods such as componentDidUpdate
. And of course, I cannot use mount
in my test because I don't want to mount the entire tree (in my case, that would mean loading my entire application).
Thus I wonder: is this a bug in enzyme, or I am missing something in my usage of that library?
Here's my code example:
import * as React from 'react';
import { connect } from 'react-redux';
import { createStore } from 'redux';
import { shallow } from 'enzyme';
import sinon from 'sinon';
const actions = {
// This would fetch a resource on the network.
getList: () => {},
receiveList: list => {
return {
type: 'RECEIVE_LIST',
list,
};
},
// This would fetch a list of resources on the network.
getObjects: () => {},
};
const reducer = (state = { list: }, action) => {
switch (action.type) {
case 'RECEIVE_LIST':
return { ...state, list: action.list };
default:
return state;
}
};
class MyAppBase extends React.Component {
componentDidMount() {
this.props.dispatch(actions.getList());
}
componentDidUpdate(nextProps) {
if (nextProps.list !== this.props.list) {
this.props.dispatch(actions.getObjects(nextProps.list));
}
}
render() {
return null;
}
}
const MyApp = connect(state => { return { list: state.list }; })(MyAppBase);
describe('<MyApp>', () => {
it('fetches objects once list is received', () => {
// Mock actions that call the network.
sinon.stub(actions, 'getList');
actions.getList.returns({type: 'whatever'});
sinon.stub(actions, 'getObjects');
actions.getObjects.returns({type: 'whatever'});
// Create a redux store.
const store = createStore(reducer);
// Create the component.
const wrapper = shallow(<MyApp store={store} />);
// Verify that `componentDidMount` was called but not `componentDidUpdate`.
expect(actions.getList.callCount).toEqual(1);
expect(actions.getObjects.callCount).toEqual(0);
// Dispatch an action that will change the redux store.
store.dispatch(actions.receiveList([ 'aa', 'bb' ]));
// Expect the `componentDidUpdate` method to be called.
expect(actions.getObjects.callCount).toEqual(1);
// This doesn't work, for some reason `componentDidUpdate` is never called.
});
});
Package versions I use for this:
"react": "16.6.0",
"react-dom": "16.6.0",
"react-redux": "5.1.0",
"redux": "4.0.1",
"enzyme": "3.7.0",
"enzyme-adapter-react-16": "1.6.0",
"sinon": "7.1.0"
Thanks!
reactjs redux react-redux enzyme
add a comment |
I'm having trouble testing a very specific use case of my React components. In this case, I have a component that dispatches an action on mount, and then dispatches another action after the results of the first dispatch come in.
The problem, I believe, comes down to enzyme's shallow
method not calling componentDidUpdate
in my component. I have reproduced the problem with the simplest code I could, and confirmed that the problem disappears if I use mount
instead of shallow
. However, enzyme's documentation says that since version 3, shallow
does call React's lifecycle methods such as componentDidUpdate
. And of course, I cannot use mount
in my test because I don't want to mount the entire tree (in my case, that would mean loading my entire application).
Thus I wonder: is this a bug in enzyme, or I am missing something in my usage of that library?
Here's my code example:
import * as React from 'react';
import { connect } from 'react-redux';
import { createStore } from 'redux';
import { shallow } from 'enzyme';
import sinon from 'sinon';
const actions = {
// This would fetch a resource on the network.
getList: () => {},
receiveList: list => {
return {
type: 'RECEIVE_LIST',
list,
};
},
// This would fetch a list of resources on the network.
getObjects: () => {},
};
const reducer = (state = { list: }, action) => {
switch (action.type) {
case 'RECEIVE_LIST':
return { ...state, list: action.list };
default:
return state;
}
};
class MyAppBase extends React.Component {
componentDidMount() {
this.props.dispatch(actions.getList());
}
componentDidUpdate(nextProps) {
if (nextProps.list !== this.props.list) {
this.props.dispatch(actions.getObjects(nextProps.list));
}
}
render() {
return null;
}
}
const MyApp = connect(state => { return { list: state.list }; })(MyAppBase);
describe('<MyApp>', () => {
it('fetches objects once list is received', () => {
// Mock actions that call the network.
sinon.stub(actions, 'getList');
actions.getList.returns({type: 'whatever'});
sinon.stub(actions, 'getObjects');
actions.getObjects.returns({type: 'whatever'});
// Create a redux store.
const store = createStore(reducer);
// Create the component.
const wrapper = shallow(<MyApp store={store} />);
// Verify that `componentDidMount` was called but not `componentDidUpdate`.
expect(actions.getList.callCount).toEqual(1);
expect(actions.getObjects.callCount).toEqual(0);
// Dispatch an action that will change the redux store.
store.dispatch(actions.receiveList([ 'aa', 'bb' ]));
// Expect the `componentDidUpdate` method to be called.
expect(actions.getObjects.callCount).toEqual(1);
// This doesn't work, for some reason `componentDidUpdate` is never called.
});
});
Package versions I use for this:
"react": "16.6.0",
"react-dom": "16.6.0",
"react-redux": "5.1.0",
"redux": "4.0.1",
"enzyme": "3.7.0",
"enzyme-adapter-react-16": "1.6.0",
"sinon": "7.1.0"
Thanks!
reactjs redux react-redux enzyme
I'm having trouble testing a very specific use case of my React components. In this case, I have a component that dispatches an action on mount, and then dispatches another action after the results of the first dispatch come in.
The problem, I believe, comes down to enzyme's shallow
method not calling componentDidUpdate
in my component. I have reproduced the problem with the simplest code I could, and confirmed that the problem disappears if I use mount
instead of shallow
. However, enzyme's documentation says that since version 3, shallow
does call React's lifecycle methods such as componentDidUpdate
. And of course, I cannot use mount
in my test because I don't want to mount the entire tree (in my case, that would mean loading my entire application).
Thus I wonder: is this a bug in enzyme, or I am missing something in my usage of that library?
Here's my code example:
import * as React from 'react';
import { connect } from 'react-redux';
import { createStore } from 'redux';
import { shallow } from 'enzyme';
import sinon from 'sinon';
const actions = {
// This would fetch a resource on the network.
getList: () => {},
receiveList: list => {
return {
type: 'RECEIVE_LIST',
list,
};
},
// This would fetch a list of resources on the network.
getObjects: () => {},
};
const reducer = (state = { list: }, action) => {
switch (action.type) {
case 'RECEIVE_LIST':
return { ...state, list: action.list };
default:
return state;
}
};
class MyAppBase extends React.Component {
componentDidMount() {
this.props.dispatch(actions.getList());
}
componentDidUpdate(nextProps) {
if (nextProps.list !== this.props.list) {
this.props.dispatch(actions.getObjects(nextProps.list));
}
}
render() {
return null;
}
}
const MyApp = connect(state => { return { list: state.list }; })(MyAppBase);
describe('<MyApp>', () => {
it('fetches objects once list is received', () => {
// Mock actions that call the network.
sinon.stub(actions, 'getList');
actions.getList.returns({type: 'whatever'});
sinon.stub(actions, 'getObjects');
actions.getObjects.returns({type: 'whatever'});
// Create a redux store.
const store = createStore(reducer);
// Create the component.
const wrapper = shallow(<MyApp store={store} />);
// Verify that `componentDidMount` was called but not `componentDidUpdate`.
expect(actions.getList.callCount).toEqual(1);
expect(actions.getObjects.callCount).toEqual(0);
// Dispatch an action that will change the redux store.
store.dispatch(actions.receiveList([ 'aa', 'bb' ]));
// Expect the `componentDidUpdate` method to be called.
expect(actions.getObjects.callCount).toEqual(1);
// This doesn't work, for some reason `componentDidUpdate` is never called.
});
});
Package versions I use for this:
"react": "16.6.0",
"react-dom": "16.6.0",
"react-redux": "5.1.0",
"redux": "4.0.1",
"enzyme": "3.7.0",
"enzyme-adapter-react-16": "1.6.0",
"sinon": "7.1.0"
Thanks!
reactjs redux react-redux enzyme
reactjs redux react-redux enzyme
asked Nov 13 '18 at 15:05
Adrian GaudebertAdrian Gaudebert
61
61
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53283896%2fenzyme-with-shallow-redux-store-update-does-not-trigger-componentdidupdate%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53283896%2fenzyme-with-shallow-redux-store-update-does-not-trigger-componentdidupdate%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown