Vfrdtyky

The string im passing is this "Tom, Wing Stop, Franklin Mountain, 28, 5, 39.16"

Im passing the string, and assigning the fields in the class to them., Im not sure why im getting this error

  public class UberUser{

  String name;

  String pickUp;

  String destination;

  int rideTime;

  int miles;

  double earning;



  public UberUser(String s){

    String line = s;

    s=s.replaceAll("\s","");



    String tokens = s.split(",");   

    this.name = tokens[0];

    this.pickUp = tokens[1];

    this.destination = tokens[2];

    this.rideTime = Integer.parseInt (tokens[3]);

    this.miles = Integer.parseInt (tokens[4]);

    this. earning = Double.parseDouble(tokens[5]);

  }



public class UberTester{

  public static void main (Stringargs)throws Exception{



    BufferedReader in = new BufferedReader(new FileReader("uberLog.txt"));

    String str;

    List<String> list = new ArrayList<String>();

    while((str = in.readLine()) != null){

      list.add(str);

    }



    List<UberUser> users = new ArrayList<UberUser>();

    for(String s :list){

    users.add(new UberUser(s));

    }

  }

}

if anybody can help me i would really appreciate it thanks!

this is the error:

java.lang.ArrayIndexOutOfBoundsException: 1

    at UberUser.<init>(UberUser.java:17)

    at UberTester.main(UberTester.java:16)

    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)

    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)

    at java.lang.reflect.Method.invoke(Unknown Source)

    at edu.rice.cs.drjava.model.compiler.JavacCompiler.runCommand(JavacCompiler.java:267)

Looks like you're not passing the string in.

class Main {

  public static void main(String args) {

    UberUser user = new UberUser("Tom, Wing Stop, Franklin Mountain,  28, 5, 39.16");

    System.out.println(user);

  }

}



class UberUser{

  String name;

  String pickUp;

  String destination;

  int rideTime;

  int miles;

  double earning;



  public UberUser(String s){

    String line = s;

    s=s.replaceAll("\s","");



    String tokens = s.split(",");   

    this.name = tokens[0];

    this.pickUp = tokens[1];

    this.destination = tokens[2];

    this.rideTime = Integer.parseInt (tokens[3]);

    this.miles = Integer.parseInt (tokens[4]);

    this. earning = Double.parseDouble(tokens[5]);

  }



  public String toString() { 

    return String.format("Name: %snPick-Up: %snDestination: %snRide Time: %dnMiles: %dnEarning: £%f", name, pickUp, destination, rideTime, miles, earning);

  }

}

Gives

java version "1.8.0_31"

Java(TM) SE Runtime Environment (build 1.8.0_31-b13)

Java HotSpot(TM) 64-Bit Server VM (build 25.31-b07, mixed mode)



Name: Tom

Pick-Up: WingStop

Destination: FranklinMountain

Ride Time: 28

Miles: 5

Earning: £39.160000

This is where using a debugger is useful as you are not using the input you think you are.

This runs without error.

class A {

    static class UberUser {

        String name;

        String pickUp;

        String destination;

        int rideTime;

        int miles;

        double earning;



        public UberUser(String s) {

            String line = s;

            s = s.replaceAll("\s", "");



            String tokens = s.split(",");

            this.name = tokens[0];

            this.pickUp = tokens[1];

            this.destination = tokens[2];

            this.rideTime = Integer.parseInt(tokens[3]);

            this.miles = Integer.parseInt(tokens[4]);

            this.earning = Double.parseDouble(tokens[5]);

        }

    }



    public static void main(String args) {

        new UberUser("Tom, Wing Stop, Franklin Mountain,  28, 5, 39.16");

    }

}

As @AndyTurner points out you should be parsing the input before calling the constructor.

class A {

    static class UberUser {

        String name;

        String pickUp;

        String destination;

        int rideTime;

        int miles;

        double earning;



        public UberUser(String name, String pickUp, String destination, int rideTime, int miles, double earning) {

            this.name = name;

            this.pickUp = pickUp;

            this.destination = destination;

            this.rideTime = rideTime;

            this.miles = miles;

            this.earning = earning;

        }



        @Override

        public String toString() {

            return "UberUser{" +

                    "name='" + name + ''' +

                    ", pickUp='" + pickUp + ''' +

                    ", destination='" + destination + ''' +

                    ", rideTime=" + rideTime +

                    ", miles=" + miles +

                    ", earning=" + earning +

                    '}';

        }

    }



    public static void main(String args) {

        String line = "Tom, Wing Stop, Franklin Mountain,  28, 5, 39.16";



        String tokens = line.trim().split(" *, *");

        String name = tokens[0];

        String pickUp = tokens[1];

        String destination = tokens[2];

        int  rideTime = Integer.parseInt(tokens[3]);

        int miles = Integer.parseInt(tokens[4]);

        double earning = Double.parseDouble(tokens[5]);

        UberUser user = new UberUser(name, pickUp, destination, rideTime, miles, earning);

        System.out.println(user);

    }

}

prints

UberUser{name='Tom', pickUp='Wing Stop', destination='Franklin Mountain', rideTime=28, miles=5, earning=39.16}

You are trying to split a String using the delimiter , Since there is no , in your String the Split only returns a single index. which is tokens[0], The problem with your code is you are trying to call tokens[1] What I would do is check if the String contains , before splitting it. Or check if tokens.length is greater then 1.

You can do a simple check by using this code

    if(!s.contains(",")){

        throw new IllegalArgumentException("Invalid String Pattern");

    }