Avoiding an unchecked cast for deepcopying map
I'm trying to implement a deepCopy method for a multi valued map like this:
public static <K, V> ListValuedMap<K, V> deepCopy (ListValuedMap<K, V> a) {
ListValuedMap<K, V> result = new ArrayListValuedHashMap<>();
a.asMap().forEach((key, value) -> {
Object newValue;
if (value instanceof ListValuedMap) {
newValue = deepCopy((ListValuedMap<K, V>) value);
‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
unchecked cast!
} else if (value instanceof Cloneable) {
try {
Method clone = value.getClass().getDeclaredMethod("clone");
newValue = clone.invoke(value);
} catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
throw new RuntimeException(e);
}
} else {
newValue = value;
}
result.put(key, (V) newValue);
‾‾‾
unchecked cast !
});
return result;
}
The second Unchecked cast can be avoided by passing the class for the V
value type paramater argument and using vClass.cast(newValue)
, but I have no idea on how to procede for the first error.
java unchecked
|
show 1 more comment
I'm trying to implement a deepCopy method for a multi valued map like this:
public static <K, V> ListValuedMap<K, V> deepCopy (ListValuedMap<K, V> a) {
ListValuedMap<K, V> result = new ArrayListValuedHashMap<>();
a.asMap().forEach((key, value) -> {
Object newValue;
if (value instanceof ListValuedMap) {
newValue = deepCopy((ListValuedMap<K, V>) value);
‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
unchecked cast!
} else if (value instanceof Cloneable) {
try {
Method clone = value.getClass().getDeclaredMethod("clone");
newValue = clone.invoke(value);
} catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
throw new RuntimeException(e);
}
} else {
newValue = value;
}
result.put(key, (V) newValue);
‾‾‾
unchecked cast !
});
return result;
}
The second Unchecked cast can be avoided by passing the class for the V
value type paramater argument and using vClass.cast(newValue)
, but I have no idea on how to procede for the first error.
java unchecked
The first can be avoided by using<?,?>
. The second cannot be avoided. Suppress it.
– Michael
Nov 16 '18 at 10:39
@Michael it's the other way around, the second maybe avoided using a class.cast the first one I cant see how
– Vinz243
Nov 16 '18 at 10:43
If you think the second can be avoided, why did you ask the question about it? It can't by the way.
– Michael
Nov 16 '18 at 10:45
result.put(key, vClass.cast(newValue)); doens't throw anything
– Vinz243
Nov 16 '18 at 10:46
You can't get V's class.
– Michael
Nov 16 '18 at 10:47
|
show 1 more comment
I'm trying to implement a deepCopy method for a multi valued map like this:
public static <K, V> ListValuedMap<K, V> deepCopy (ListValuedMap<K, V> a) {
ListValuedMap<K, V> result = new ArrayListValuedHashMap<>();
a.asMap().forEach((key, value) -> {
Object newValue;
if (value instanceof ListValuedMap) {
newValue = deepCopy((ListValuedMap<K, V>) value);
‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
unchecked cast!
} else if (value instanceof Cloneable) {
try {
Method clone = value.getClass().getDeclaredMethod("clone");
newValue = clone.invoke(value);
} catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
throw new RuntimeException(e);
}
} else {
newValue = value;
}
result.put(key, (V) newValue);
‾‾‾
unchecked cast !
});
return result;
}
The second Unchecked cast can be avoided by passing the class for the V
value type paramater argument and using vClass.cast(newValue)
, but I have no idea on how to procede for the first error.
java unchecked
I'm trying to implement a deepCopy method for a multi valued map like this:
public static <K, V> ListValuedMap<K, V> deepCopy (ListValuedMap<K, V> a) {
ListValuedMap<K, V> result = new ArrayListValuedHashMap<>();
a.asMap().forEach((key, value) -> {
Object newValue;
if (value instanceof ListValuedMap) {
newValue = deepCopy((ListValuedMap<K, V>) value);
‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾‾
unchecked cast!
} else if (value instanceof Cloneable) {
try {
Method clone = value.getClass().getDeclaredMethod("clone");
newValue = clone.invoke(value);
} catch (NoSuchMethodException | IllegalAccessException | InvocationTargetException e) {
throw new RuntimeException(e);
}
} else {
newValue = value;
}
result.put(key, (V) newValue);
‾‾‾
unchecked cast !
});
return result;
}
The second Unchecked cast can be avoided by passing the class for the V
value type paramater argument and using vClass.cast(newValue)
, but I have no idea on how to procede for the first error.
java unchecked
java unchecked
asked Nov 16 '18 at 10:17
Vinz243Vinz243
4,18453169
4,18453169
The first can be avoided by using<?,?>
. The second cannot be avoided. Suppress it.
– Michael
Nov 16 '18 at 10:39
@Michael it's the other way around, the second maybe avoided using a class.cast the first one I cant see how
– Vinz243
Nov 16 '18 at 10:43
If you think the second can be avoided, why did you ask the question about it? It can't by the way.
– Michael
Nov 16 '18 at 10:45
result.put(key, vClass.cast(newValue)); doens't throw anything
– Vinz243
Nov 16 '18 at 10:46
You can't get V's class.
– Michael
Nov 16 '18 at 10:47
|
show 1 more comment
The first can be avoided by using<?,?>
. The second cannot be avoided. Suppress it.
– Michael
Nov 16 '18 at 10:39
@Michael it's the other way around, the second maybe avoided using a class.cast the first one I cant see how
– Vinz243
Nov 16 '18 at 10:43
If you think the second can be avoided, why did you ask the question about it? It can't by the way.
– Michael
Nov 16 '18 at 10:45
result.put(key, vClass.cast(newValue)); doens't throw anything
– Vinz243
Nov 16 '18 at 10:46
You can't get V's class.
– Michael
Nov 16 '18 at 10:47
The first can be avoided by using
<?,?>
. The second cannot be avoided. Suppress it.– Michael
Nov 16 '18 at 10:39
The first can be avoided by using
<?,?>
. The second cannot be avoided. Suppress it.– Michael
Nov 16 '18 at 10:39
@Michael it's the other way around, the second maybe avoided using a class.cast the first one I cant see how
– Vinz243
Nov 16 '18 at 10:43
@Michael it's the other way around, the second maybe avoided using a class.cast the first one I cant see how
– Vinz243
Nov 16 '18 at 10:43
If you think the second can be avoided, why did you ask the question about it? It can't by the way.
– Michael
Nov 16 '18 at 10:45
If you think the second can be avoided, why did you ask the question about it? It can't by the way.
– Michael
Nov 16 '18 at 10:45
result.put(key, vClass.cast(newValue)); doens't throw anything
– Vinz243
Nov 16 '18 at 10:46
result.put(key, vClass.cast(newValue)); doens't throw anything
– Vinz243
Nov 16 '18 at 10:46
You can't get V's class.
– Michael
Nov 16 '18 at 10:47
You can't get V's class.
– Michael
Nov 16 '18 at 10:47
|
show 1 more comment
0
active
oldest
votes
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53335751%2favoiding-an-unchecked-cast-for-deepcopying-map%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53335751%2favoiding-an-unchecked-cast-for-deepcopying-map%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
The first can be avoided by using
<?,?>
. The second cannot be avoided. Suppress it.– Michael
Nov 16 '18 at 10:39
@Michael it's the other way around, the second maybe avoided using a class.cast the first one I cant see how
– Vinz243
Nov 16 '18 at 10:43
If you think the second can be avoided, why did you ask the question about it? It can't by the way.
– Michael
Nov 16 '18 at 10:45
result.put(key, vClass.cast(newValue)); doens't throw anything
– Vinz243
Nov 16 '18 at 10:46
You can't get V's class.
– Michael
Nov 16 '18 at 10:47